remove the fencp.apk and ffxcp.apk from the tegras

RESOLVED WONTFIX

Status

Release Engineering
General
P3
normal
RESOLVED WONTFIX
6 years ago
5 years ago

People

(Reporter: jmaher, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile][cleanup])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We don't need the sharedID anymore for our unittests.  So we can now remove the fencp.apk (org.mozilla.fencp) and ffxcp.apk (org.mozilla.ffxcp) from our tegras.

This is critical because we can't install our robocop instrumented builds while fencp exists on the device.

We need to update the documentation and do a sweep through all the tegras to clean them up.

For the documentation we just need to install watcher.apk and sutagentandroid.apk.

Updated

6 years ago
Priority: -- → P3
Whiteboard: [mobile][cleanup]
(Assignee)

Comment 1

6 years ago
(In reply to Joel Maher (:jmaher) from comment #0)
> This is critical because we can't install our robocop instrumented builds
> while fencp exists on the device.

Not critical anymore, per Joel. And we should be good with 'just' additions to the cleanup script, and modifications to our "setup a new tegra" documentation to no longer install these.
Assignee: nobody → bugspam.Callek
(Assignee)

Comment 2

6 years ago
Created attachment 629707 [details] [diff] [review]
[tools] v1

This should do it, just adding it to cleanup. [not yet staged, but will run through staging for a day or two before I toss at prod]
Attachment #629707 - Flags: review?(bear)

Updated

6 years ago
Attachment #629707 - Flags: review?(bear) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 629707 [details] [diff] [review]
[tools] v1

While staging this I see (in the reboot steps logcat) a LOT of:

06-20 20:25:11.196 E/ActivityThread( 1455): Failed to find provider info for org.mozilla.ffxcp
06-20 20:25:11.326 E/ActivityThread( 1455): Failed to find provider info for org.mozilla.fencp

where each could be listed anywhere/any-amount-of-time.  Is this a misnomer, what provides these messages, is this something we should cleanup before this deploys, should this still deploy, or what?
Attachment #629707 - Flags: review?(jmaher)
(Reporter)

Comment 5

6 years ago
I suspect it is sutagent looking for those providers and if they exist use them.
(Reporter)

Comment 6

6 years ago
after discussing in IRC, we have a lot of references to this in the code and there could be a chance in the future we might want to use these.  So it makes sense to keep references in the code even if it just gives warnings in the logfile.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 7

6 years ago
(In reply to Joel Maher (:jmaher) from comment #6)
> after discussing in IRC, we have a lot of references to this in the code and
> there could be a chance in the future we might want to use these.  So it
> makes sense to keep references in the code even if it just gives warnings in
> the logfile.

To be clear, the SUTAgent currently references it in a few seperate places, and :jmaher isn't prepared to rip out those references now, incase we need them (or something similar) in the future.

This patch was never actually deployed [beyond staging], so I'm just backing it out, and we'll plan to get these tegras reimaged for sanity later.

http://hg.mozilla.org/build/tools/rev/928a786d8787
(Assignee)

Comment 8

6 years ago
Comment on attachment 629707 [details] [diff] [review]
[tools] v1

Review of attachment 629707 [details] [diff] [review]:
-----------------------------------------------------------------

self r- since we backed this out
Attachment #629707 - Flags: review?(jmaher) → review-
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.