714160 - apps: installs_allowed_from should not be required

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P2)

Description

[Ian Bicking (:ianbicking)]

The manifest property "installs_allowed_from" is not required; in its absence the value is assumed to be ["*"].

Also though both name and URL are defined for the "developer" property, neither are required - submitting with only a name gives an error.

Once you succeed you get a message "Your app passed validation with no errors and 1 message." - the one message being a positive "App confirmed."  This is kind of distracting.  Also in the detailed report this is called a warning.

Comment 1

[krupa raj[:krupa]]

(In reply to Ian Bicking (:ianb) from comment #0)

> This is kind of distracting.  Also in the detailed report this is called a
> warning.

That is bug 677583.

Comment 3

[Kumar McMillan [:kumar]]

basta, can you update the validator so it doesn't require installs_allowed_from in manifests?

Comment 4

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/amo-validator/pull/114

Comment 5

[[e-mail]]

I tried this manifest and still get the same error :

{
    "name": "MozApps Hello World",
    "description": "MozApps Hello World does absolutly nothing.",
    "launch_path": "http://helloworld.webruntime.com/index.html",
    "developer": {
        "name": "Misfit Geek",
        "url": "http://www.misfitgeek.com/"
    },
    "icons": {
        "128": "icon128.png"
    },
    "installs_allowed_from": [
        "*"
    ]
}

Comment 6

[Kumar McMillan [:kumar]]

Merged: https://github.com/mozilla/amo-validator/commit/6a9875b526049efbbf541f84e90bca167f06d2ad

Pushed to AMO https://github.com/mozilla/zamboni/commit/43953c2

Comment 7

[Kumar McMillan [:kumar]]

(In reply to [e-mail] from comment #5)
> I tried this manifest and still get the same error :

what error are you getting? and which site are you submitting to? the code has not been deployed yet.

Comment 8

[[e-mail]]

I'm submitting here : 

https://apps-preview.mozilla.org/en-US/developers/app/submit/2

And getting this error : 

General Tests
1 error, 0 warnings
App: JSON Parse Error

Error: The webapp extension could not be parsed due to a syntax error in the JSON.

Comment 9

[Kumar McMillan [:kumar]]

btw I made bug 721098 for the developer.url bug

Comment 10

[Matt Basta [:basta]]

(In reply to [e-mail] from comment #8)
> General Tests
> 1 error, 0 warnings
> App: JSON Parse Error
> 
> Error: The webapp extension could not be parsed due to a syntax error in the
> JSON.

This means that the JSON for your manifest isn't written properly. Attach the file that you're submitting and I'll have a look.

Comment 11

[Christopher Van Wiemeersch [:cvan]]

As I mentioned here, https://bugzilla.mozilla.org/show_bug.cgi?id=721051#c4, the launch_path is incorrect.

Comment 12

[[e-mail]]

Attachment: Manifest file that produces JSON parse error.

JSONLint validates it as valid JSON

Comment 13

[Kumar McMillan [:kumar]]

(In reply to [e-mail] from comment #8)
> Error: The webapp extension could not be parsed due to a syntax error in the
> JSON.

I can't reproduce this error when copying/pasting your json into a manifest http://people.mozilla.com/~kmcmillan/bug714160.webapp

Can you paste the URL to the manifest you are using? It might be another encoding issue.

Comment 14

[[e-mail]]

I removed the launch path entry and still get the error :

http://helloworld.webruntime.com/manifest.webapp

Comment 15

[Kumar McMillan [:kumar]]

Aha, this is the BOM error again. I created bug 721103 for it. Thanks!

Comment 16

[[e-mail]]

Yes ! I stripped the BOM with vi and the file now parses.

Comment 17

[krupa raj[:krupa]]

installs_allowed_from is not a required field anymore.