714230 - Opening new tabs in the background suppresses rendering and it never unsuppresses

Status: VERIFIED FIXED

Description

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

My patches for bug 709492 made tabs opened in the background no longer appear. Sorry. Here's a fix.

Comment 1

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Comment on attachment 584918 [details] [diff] [review]
Proposed patch.

Review of attachment 584918 [details] [diff] [review]:
-----------------------------------------------------------------

Good thing you caught it early :)

Comment 2

[Patrick Walton (:pcwalton)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2610136fb54

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d4c526ba5343

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Patrick, please request aurora approval

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 584918 [details] [diff] [review]
Proposed patch.

[Triage Comment]
Needed on beta since it fixes a regression caused by bug 709492 which is on beta

Comment 6

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

(In reply to Phil Ringnalda (:philor) from comment #3)
> https://hg.mozilla.org/mozilla-central/rev/d4c526ba5343

This should really say https://hg.mozilla.org/mozilla-central/rev/f2610136fb54

Comment 7

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

So this patch was actually backed out as part of the backout of bug 709492 (see comment 61 on that bug), and the modified re-landed version didn't need this patch. So it doesn't need to be uplifted anywhere.

Comment 8

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Comment on attachment 584918 [details] [diff] [review]
Proposed patch.

Removing beta approval since this doesn't need to be uplifted.

Comment 9

[Andreea Pod]

This is only about the tabs opened in background that were not appearing or I should look at some other bad behavior also in order to verify it?

Comment 10

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Yeah, this is only about tabs opened in background. STR would be something like:

1) Open some page
2) Long tap on a link, open new tab
3) Wait a while for the background tab to finish loading
4) Switch to the new tab

If the new tab shows up normally then that's good. You can also try without step 3, so switching tabs while it's still loading. That should work as well.

Comment 11

[Paul Feher]

Verified on:
Nightly Fennec 13.0a1 (2012-03-04)
Device: HTC Desire Z
OS: Android 2.3.3

The new tab shows up normally.