Closed Bug 714244 Opened 8 years ago Closed 6 years ago

[sk] Search Engine modification for Thunderbird

Categories

(Mozilla Localizations :: sk / Slovak, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wladow, Assigned: wladow)

References

Details

(Keywords: productization)

Attachments

(2 files, 2 obsolete files)

Initial commit for TB Search Engines already done (sorry about that).

It's just reusing the en-US engines:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sk/diff/395764653fea/mail/chrome/messenger-region/region.properties

http://hg.mozilla.org/releases/l10n/mozilla-aurora/sk/diff/395764653fea/mail/searchplugins/list.txt

We will make a few changes to the list in the near future
Attachment #584933 - Flags: review?(mbanner)
Comment on attachment 584933 [details] [diff] [review]
copy en-us search engines to sk for now

Ok, that's fine. Please leave this bug open for your selection of the engines specific to your locale.
Attachment #584933 - Flags: review?(mbanner) → review+
FYI, as you're using the en-US search engines for now, and have a bug, I've now accepted the sign-off you previously submitted for aurora branch and ported it across to beta for TB 10.
Attached patch add localized search plug-ins (obsolete) — Splinter Review
This patch is adding basically the same search plug-in set as the one we are currently using in Firefox.

The list of the plug-ins:
google
azet-sk
atlas-sk
bing
eBay
slovnik-sk
wikipedia-sk
zoznam-sk

atlas.sk, azet.sk and zoznam.sk are the generic search plug-ins, slovnik.sk is a specific interest search (en->sk dictionary), we'd like to use localized Wikipedia too. We are leaving the google, bing and eBay as they are.

Tested with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0a1) Gecko/20120206 Thunderbird/13.0a1
Attachment #594756 - Flags: review?(mbanner)
Resolution of bug 732240 may lead to a slight change to the patch. Let's resolve that bug first.
Depends on: 732240
Comment on attachment 594756 [details] [diff] [review]
add localized search plug-ins

I'm sorry I've not been able to complete on finding a resolution to the other bug yet. However, I think for now we could get this landed, as it doesn't actually change the main situation, but just means your users can have access to irc if they want to.

The only thing I can see is that we want to change these:

browser.search.order.2=Yahoo
browser.search.order.3=Bing

in mail/chrome/messenger-region/region.properties so that Yahoo isn't in the list (having been removed), and Bing is second, with a possibility for one of the localised versions as third?
Attachment #594756 - Flags: review?(mbanner) → feedback+
Attached patch Final patch (obsolete) — Splinter Review
Final version of the patch, carrying over the r+ and landing to l10n-central. Going to land to releases/l10n/mozilla-aurora and releases/l10n/mozilla-beta soon.

Thanks.
Attachment #826485 - Flags: review+
Comment on attachment 826485 [details] [diff] [review]
Final patch

Review of attachment 826485 [details] [diff] [review]:
-----------------------------------------------------------------

I'd only give f+ in the previous patch... but anyway, I just noticed a couple of changes between this patch and the last one.

::: mail/searchplugins/atlas-sk.xml
@@ +4,5 @@
> +<InputEncoding>UTF-8</InputEncoding>
> +<Image width="16" height="16">data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAALESURBVHjaYvz//z8DMvj7nuHXY4YfLxiA4hziDJzyDIyCyPIAAcSCYP55w/Bi7deHW188e/H5B/tfRg5mVnZuAWEJVXteWR8GVjGIKoAAYoTa8P3mz0tVj27f+8rrIazmxSkgx8TM+v/fr6/vH768vZ+L7aOKZTI7vw5QIUAAAW3+///7ve8H3W+sCHh+59zf/+jgz5//j64fO7e16fPrG0AuQAAxAI35e7n4xVr3L68f/8cNnt27fOXQit+/vgMEEOP/z5d+HMn+r97Eqehw/9Wf5Ue+/vrDyMLCxMLIyMTMKMzDbKPBqi7FBHTMz+/f2Dg4AAKIheH9JUYuTTYZK6DQ07d/Zu36+O0HIzs7MzMTEysrMycH26Zzv0t9OW3Umdk5uYBqAAKI5e+394y8mkysbECOhjRLTzTX9x9/mZiY/v//t+/0g1MvJO+/5t989pe5CicrM8jPAAHExMDE85+ZCxJkInwsqrJ8Pxk43nxl+vybjY2V9d+fn3/+Mjx88+/nb2h0AQQQCxOPIsvvuxDOhpPfGtd8fvWJgY0V6KL/zMyKzBwM//7++/2PCR67AAHExCigwcDMzvDn8/ffDGtOfHvwhoH970c7yftxhi9Nuc/+/vjk9z/mv38Z4dELEEAsDJxijJL2DEws//8w/GdgYmX+//c/44GTDw7/+/Lr509maTEmBsa///4zwKwACCBg0mD8zyPz689v5v8/HDUZTt399+OPMLO8x39GBjZGRqDCn7///vqDSEEAAcQCTBk/vn9/9+79t29fjcV/ZZp9P3Pv7/effxkY/nNyccnJyvAL8EkJMLGxQF0FEEDA+GFgZWVhYWUFJoGvX75JsT4zFXzz7t2nX7//crNwG4rquTiYcnKywm0ACCBGePL+8/fvn99/fv768+Pn71+//gDjAehadnY2QX4eNjZmuAaAAAMA9HBNfsA2E5MAAAAASUVORK5CYII=</Image>
> +<Url type="text/html" method="GET" template="http://www.atlas.sk/search.php">
> +  <Param name="phrase" value="{searchTerms}"/>
> +  <Param name="sourceid" value="firefox"/>

Leave the sourceid out here - I don't know if we have agreements with them or not, but we probably shouldn't pretend to be FF anyway.

::: mail/searchplugins/slovnik-sk.xml
@@ +5,5 @@
> +<Image width="16" height="16">data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAACjUlEQVQ4jTWTzWueRRTFf2dm3rwhamxIYlqkNV8aPza2oAYtiO5FKdWFK62u/ANUEF0qgls3dVNdiOBKQdBFSupH0VIQFFNfq6mkWiU0ao1om+eZe1w8b2Yzmzlz7++ee3TLi1dNGKUKLkDCNGQyoSA5qCoApDCSaDFJJmxKNvz4Wh9cIWVsgwoCDMh0R91lAoUgiYUXGkqlgsDK4K4CDv7YEdvbnWp8rGVirAw/TJDANDiZkpzoigQS/P4nvHdWrPzQsr4JES1Le3sc3G+euC9Ymkl0ih5BQ4kkZAgSNcxLH+zw8bdmclwsTFdGSmbtUvDlesPqOfHWsVEWpjuNHBQRhCoJ8elP5uSgx8T4DkfuLrz8SJ+c4OT3lVc+NFebAmoRBQvYRUhkAK7VCm4YTYnLf4uzGzA7ETx0e2b11szl7crePQUcSAm5UELRDSfg8Hzm8GLL6fPik3PX+GgNZicSt+1LPLgkjhzK3VvScGqVYrtzSJXr+pl3nhnhxBctK4PCb3+Z9S24sGlWBpX3z8Abj2fmZ4QIEqJkBASQqQFrl8SjBwtPPyAubJnzm+bUoHJqAGc2guOfwetHCziRgGKLCmTg85+Dp443zE3Bq4+NsLxo5qYSMzfC6kAkB40DuyIyLaZYIjuBgpv6Yup68c0v5rl3g4fv3GHPaI+vLwa/Xqnsu6HH0UNCZAI6BLliwIg7bhZvPtnj7a+C7zbMidOZf/4NZqdhebHHs8uJ+xdiuNKAWkpVQgJhbHHvvLlnPnNxy2xeKWw3LZNjhbv2d5i7jmUMLpSCsN35upsbVw5MZg5Mdo1CYFIXNARpCOCK5p7/z04VW5hEkOiry0CbM4ouuqqZyAY3Q/qMLf4HXuEzGm+s4N8AAAAASUVORK5CYII=</Image>
> +<Url type="text/html" method="GET" template="http://slovnik.sk/">
> +  <Param name="q" value="{searchTerms}"/>
> +  <Param name="l" value="en-sk"/>
> +  <Param name="sourceid" value="firefox"/>

Ditto, please drop sourceid.
Attachment #826485 - Flags: review+ → review-
Attached patch Final Patch, v2Splinter Review
I have backed out the revision and updated the patch. Hopefully everything's sorted out now. Thanks
Attachment #594756 - Attachment is obsolete: true
Attachment #826485 - Attachment is obsolete: true
Attachment #829933 - Flags: review?(mbanner)
Comment on attachment 829933 [details] [diff] [review]
Final Patch, v2

Review of attachment 829933 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, looks good. r=Standard8
Attachment #829933 - Flags: review?(mbanner) → review+
You need to log in before you can comment on or make changes to this bug.