Closed
Bug 714313
Opened 12 years ago
Closed 12 years ago
Test slaves should run on random choice of slave, not slave that most recently run same job type
Categories
(Release Engineering :: General, enhancement, P5)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
References
Details
(Whiteboard: [automation][testing][sheriff-want])
Attachments
(2 files, 2 obsolete files)
3.75 KB,
patch
|
catlee
:
review+
|
Details | Diff | Splinter Review |
4.00 KB,
patch
|
catlee
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
There's no benefit to running on the same slave as most recently ran this same test, and it can make debugging test failures harder if they only seem to appear on a small subset of slaves.
Updated•12 years ago
|
Severity: normal → enhancement
Priority: -- → P5
Whiteboard: [automation][testing]
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → catlee
Updated•12 years ago
|
Whiteboard: [automation][testing] → [automation][testing][sheriff-want]
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #670794 -
Flags: review?(rail)
Comment 2•12 years ago
|
||
Comment on attachment 670794 [details] [diff] [review] Remove nextSlave for test jobs; clean up _nextOldTegra nit: do we really want recentSort() here for tegras if we're removing _next*Slave for test jobs?
Assignee | ||
Comment 3•12 years ago
|
||
Yep, good point. I'll rework it.
Comment 4•12 years ago
|
||
Comment on attachment 670794 [details] [diff] [review] Remove nextSlave for test jobs; clean up _nextOldTegra (In reply to Chris AtLee [:catlee] from comment #3) > Yep, good point. I'll rework it. OK!
Attachment #670794 -
Flags: review?(rail)
Assignee | ||
Comment 5•12 years ago
|
||
Also addresses bug 795649
Attachment #670794 -
Attachment is obsolete: true
Attachment #670820 -
Flags: review?(rail)
Comment 6•12 years ago
|
||
Comment on attachment 670820 [details] [diff] [review] Remove nextSlave for test jobs; clean up _nextOldTegra; only consider successful jobs for recent-ness Review of attachment 670820 [details] [diff] [review]: ----------------------------------------------------------------- ::: misc.py @@ +351,5 @@ > +def _nextOldTegra(builder, available_slaves): > + old = [] > + for s in available_slaves: > + number = s.slave.slavename.replace('tegra-', '') > + if int(number) < 286: There is a small chance for an exception here, but buildbot can handle that gracefully.
Attachment #670820 -
Flags: review?(rail) → review+
Assignee | ||
Comment 7•12 years ago
|
||
carrying over r+ from before, and additional r+ via email for the extra try/except handling
Attachment #670820 -
Attachment is obsolete: true
Attachment #670905 -
Flags: review+
Assignee | ||
Comment 8•12 years ago
|
||
third time's the charm? added special handling for failure to parse the number out of the slave name so we still have a chance of getting an old slave.
Attachment #670935 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Attachment #670935 -
Flags: checked-in+
Comment 9•12 years ago
|
||
http://hg.mozilla.org/build/buildbotcustom/rev/134c0504ddc9 in production
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•