Closed Bug 714313 Opened 12 years ago Closed 12 years ago

Test slaves should run on random choice of slave, not slave that most recently run same job type

Categories

(Release Engineering :: General, enhancement, P5)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: catlee, Assigned: catlee)

References

Details

(Whiteboard: [automation][testing][sheriff-want])

Attachments

(2 files, 2 obsolete files)

There's no benefit to running on the same slave as most recently ran this same test, and it can make debugging test failures harder if they only seem to appear on a small subset of slaves.
Severity: normal → enhancement
Priority: -- → P5
Whiteboard: [automation][testing]
Blocks: 795649
Assignee: nobody → catlee
Whiteboard: [automation][testing] → [automation][testing][sheriff-want]
Attachment #670794 - Flags: review?(rail)
Comment on attachment 670794 [details] [diff] [review]
Remove nextSlave for test jobs; clean up _nextOldTegra

nit: do we really want recentSort() here for tegras if we're removing _next*Slave for test jobs?
Yep, good point. I'll rework it.
Comment on attachment 670794 [details] [diff] [review]
Remove nextSlave for test jobs; clean up _nextOldTegra

(In reply to Chris AtLee [:catlee] from comment #3)
> Yep, good point. I'll rework it.

OK!
Attachment #670794 - Flags: review?(rail)
Also addresses bug 795649
Attachment #670794 - Attachment is obsolete: true
Attachment #670820 - Flags: review?(rail)
Comment on attachment 670820 [details] [diff] [review]
Remove nextSlave for test jobs; clean up _nextOldTegra; only consider successful jobs for recent-ness

Review of attachment 670820 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +351,5 @@
> +def _nextOldTegra(builder, available_slaves):
> +    old = []
> +    for s in available_slaves:
> +        number = s.slave.slavename.replace('tegra-', '')
> +        if int(number) < 286:

There is a small chance for an exception here, but buildbot can handle that gracefully.
Attachment #670820 - Flags: review?(rail) → review+
carrying over r+ from before, and additional r+ via email for the extra try/except handling
Attachment #670820 - Attachment is obsolete: true
Attachment #670905 - Flags: review+
third time's the charm? added special handling for failure to parse the number out of the slave name so we still have a chance of getting an old slave.
Attachment #670935 - Flags: review+
Attachment #670935 - Flags: checked-in+
http://hg.mozilla.org/build/buildbotcustom/rev/134c0504ddc9 in production
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.