Multiple clicks of the reply link on comments keeps adding the reply text to the new comment box

RESOLVED FIXED in Bugzilla 4.4

Status

()

--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mike_x_spraggett, Assigned: dkl)

Tracking

4.0.3
Bugzilla 4.4
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E)

Steps to reproduce:

Navigate to open bug (with comments!)

Scroll down to comments
Click on Reply 
Click on reply again (Same comment)


Actual results:

The reply text will be added twice to the new comment box


Expected results:

Reply text should only be added once.

Any of the below behaviours would be acceptable
--> ignore the second click on a specific comment
--> Remove reply text from the comment box and add at the end
--> Remove the reply text once clicked
Assignee: nobody → create-and-change
Component: User Interface → Creating/Changing Bugs
Product: bugzilla.mozilla.org → Bugzilla
QA Contact: ui → default-qa
Version: Current → 4.0.3

Comment 1

7 years ago
This is very minor. And none of your suggestion would work. Personally, I happen to click the Reply link, remove parts of the comment which I consider irrelevant, then realize that I should also reply to another part of the comment and click Reply again, etc... I'm a heavy user of Bugzilla, and I don't want the Reply link to disappear or to remove what I already wrote. If you don't want to see several times the same reply, don't click Reply several times. :)
Severity: normal → minor
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 2

7 years ago
The circumstance that this was picked up was when a user clicked reply on a VERY long comment and then clicked a further 3 times. They added their reply to the end of the text and we ended up with a very long thread, this was compounded by another user replying to the long comment.
Perhaps a better fix would be if no additional text has been added to a reply when reply is clicked again it would not add in that circumstance, that would mean your usage scenario would still be valid.
I could have sworn i raised this as minor but obviously didn't and haven't reopened but still feel it is a valid bug.
(Assignee)

Updated

7 years ago
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WONTFIX → ---
(Assignee)

Comment 3

7 years ago
Created attachment 588436 [details] [diff] [review]
Patch to  block reply if no changes made (v1)

Actually it is not a difficult fix to block adding new reply text if no changes had been made to the comment text area. This patch will do that. If someone does type something in the text area then hitting reply again will paste the text again.

Please review
dkl
Assignee: create-and-change → dkl
Status: REOPENED → ASSIGNED
Attachment #588436 - Flags: review?(LpSolit)

Comment 4

7 years ago
Comment on attachment 588436 [details] [diff] [review]
Patch to  block reply if no changes made (v1)

This only fixes the trivial case where the user clicks the Reply link several times in a row and does nothing else. If he changes one single character in the comment field, then your trick won't work and the comment will be re-added indefinitely. So it's very easy to work around this protection. But this doesn't hurt. r=LpSolit
Attachment #588436 - Flags: review?(LpSolit) → review+

Updated

7 years ago
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Comment 5

7 years ago
Thanks. Checked into trunk as well as BMO.

bugzilla/trunk:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk
modified template/en/default/bug/comments.html.tmpl
Committed revision 8080.

bmo/4.0:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified template/en/default/bug/comments.html.tmpl
Committed revision 8026.

bmo/4.2:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified template/en/default/bug/comments.html.tmpl
Committed revision 8016.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.