714360 - Evaluating something in the error console disables the copy command [Mac]

Status: RESOLVED DUPLICATE of bug 1208734

(DevTools :: Console, defect)

Description

[(no longer active)]

STR:

1. Open the error console.
2. Type "1" in the text box and press Evaluate.
3. Right click any item in the error console.  The Copy command is disabled.

Comment 1

[Philip Chee]

WORKSFORME:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20111230 Firefox/12.0a1 SeaMonkey/2.9a1

Tested with both the native Toolkit Error Console and Console² <http://console2.mozdev.org/index.html<

I tried both |"1"| and |1|

Does this happen in safe-mode?

Comment 2

[(no longer active)]

Yes, this is a problem in the implementation of the Copy menu item.  The implementation is basically broken, as it interferes with cmd_copy belonging to the textbox.

Comment 3

[(no longer active)]

To be more clear, this is a *Mac-only* issue.

Comment 4

[Philip Chee]

Going backwards the only Mac specific change I could find is:
Bug 576135 - Initial right-click on xul:textbox should not have 'cut', 'copy', and 'delete' context menu items disabled

Comment 5

[Philip Chee]

Possibly related: Bug 721860 addonBar keyboard shortcut enabled in non-browser windows.

Comment 6

[Philip Chee]

Ehsan, do you have time to do a bisect? I'm not on Mac.

Comment 7

[(no longer active)]

Sorry, this is very low on my very large todo list, especially since the bisection session will be extremely wrong.  It probably will go into the period where we couldn't build on 10.6, so I need to have a 10.5 machine as well, which I don't.  :/

Also, I looked into the code when I filed the bug.  Comment 2 captures what I had in mind, but I realize that I should have added more information there.  I don't exactly remember what I saw, but I have a very strong feeling that this is not a regression, and the implementation had this bug from day 1.  I think the problem was that we'd mix up copying items from the console to cmd_copy, which also handles copying stuff from the textbox.

Comment 8

[Wayne Mery (:wsmwk)]

does it still reproduce?

Comment 9

[Frankie]

Mac FF 21b: yes, Copy command becomes disabled after an evaluate.

Comment 10

[Brian Grinstead [:bgrins]]

The Error Console has been removed in favor of the Browser Console (see Bug 1278368), and the component is going to be removed.  If this bug is also relevant in the Browser Console, please reopen and move this into Firefox -> Developer Tools: Console.

Comment 11

[Zack Weinberg (:zwol)]

I am mass-reopening and re-componenting every single one of the Toolkit:Error Console bugs that appear to have been closed without anyone even *glancing* at whether they were relevant to the Browser Console.

If you want to close a whole bunch of old bugs -- FOR ANY REASON -- it is YOUR RESPONSIBILITY to check EVERY SINGLE ONE OF THEM and make sure they are no longer valid.  Do not push that work onto the bug reporters.

(It's okay to close bugs that haven't been touched in years when they don't have enough information for you to figure out whether the problem is still relevant to the current software - the reporter probably isn't coming back to clarify.  But that is the ONLY situation where it is okay.)

(I'm going to have to do this in two steps because of the way the "change several bugs at once" form works.  Apologies for the extra bugspam.)