Last Comment Bug 714391 - Text on disabled toolbar buttons in the menubar doesn't look disabled
: Text on disabled toolbar buttons in the menubar doesn't look disabled
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Linux
: -- trivial (vote)
: Thunderbird 12.0
Assigned To: Jim Porter (:squib)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-30 17:04 PST by Jim Porter (:squib)
Modified: 2012-01-14 18:16 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The problem (17.16 KB, image/png)
2011-12-30 17:04 PST, Jim Porter (:squib)
no flags Details
The solution (465 bytes, patch)
2011-12-30 17:05 PST, Jim Porter (:squib)
mconley: review+
bwinton: ui‑review+
Details | Diff | Review
The solution in action (16.60 KB, image/png)
2012-01-10 12:57 PST, Mike Conley (:mconley) - (needinfo me!)
no flags Details

Description Jim Porter (:squib) 2011-12-30 17:04:23 PST
Created attachment 585084 [details]
The problem

On the list of "theme bugs which no one will probably ever encounter in practice", I imagine this one rates in the top 10. Nevertheless, I noticed that disabled toolbar buttons added to the menubar have text that looks enabled. Let's fix this, especially since it's really easy to do.
Comment 1 Jim Porter (:squib) 2011-12-30 17:05:54 PST
Created attachment 585085 [details] [diff] [review]
The solution

And here's the fix. Easy-peasy.
Comment 2 Mike Conley (:mconley) - (needinfo me!) 2012-01-04 07:29:48 PST
Comment on attachment 585085 [details] [diff] [review]
The solution

Looks good to me - thanks,

-Mike
Comment 3 Mike Conley (:mconley) - (needinfo me!) 2012-01-10 12:57:22 PST
Created attachment 587439 [details]
The solution in action
Comment 4 Blake Winton (:bwinton) (:☕️) 2012-01-10 12:58:12 PST
Comment on attachment 585085 [details] [diff] [review]
The solution

It's subtle, but I like it.  ui-r=me.
Comment 5 Jim Porter (:squib) 2012-01-14 18:13:10 PST
Checked in: http://hg.mozilla.org/comm-central/rev/f1d6a28d0396

Note You need to log in before you can comment on or make changes to this bug.