Remove nsIXPCScriptable::DONT_SHARE_PROTOTYPE (and make all XPCWNProtos be shared)

RESOLVED FIXED in mozilla12

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 585110 [details] [diff] [review]
patch

We appear to support singleton XPCWrappedNativeProtos, but I don't think this is ever used. I checked MXR and I added an assertion and got a green on try. So this should be safe.

May our invariants grow stronger each day!

I'd also like to get rid of these uppercase variable names. They're awful.
Attachment #585110 - Flags: review?(bobbyholley+bmo)
Comment on attachment 585110 [details] [diff] [review]
patch

Looks good!

This needs sr, I think. I'm guessing we don't need to rev the IDL here since it's just a constant, but blake would know for sure. Flagging him for sr.
Attachment #585110 - Flags: superreview?(mrbkap)
Attachment #585110 - Flags: review?(bobbyholley+bmo)
Attachment #585110 - Flags: review+
(In reply to Bill McCloskey (:billm) from comment #0) 
> I'd also like to get rid of these uppercase variable names. They're awful.

I'd guess that they'd be going away with the new DOM bindings, so it's probably better to just wait. :-)
No, removing enums is binary compatible.

Updated

5 years ago
Attachment #585110 - Flags: superreview?(mrbkap) → superreview+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dc627b6158d
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/1dc627b6158d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.