714422 - Silence 271 warnings due to GetCurrentProcessArchitecture being a *static* inline, never used, when building with clang

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

I suspect whoever wrote the current code this way was a C programmer, because C's inline specifier is weird, generally requiring either extern/static on such declarations.  In C++ there's no weirdness to inline, I think at least partly due to the One Definition Rule.  This is a C++ header (see the <map>/<string>/<vector> includes), so just get rid of "static" entirely.

More fun with the topic here, if you're interested in knowing more:

http://adamrosenfield.com/blog/2011/03/21/the-tricky-inline-specifier-in-c99/

Comment 1

[Daniel Holbert [:dholbert]]

Comment on attachment 585112 [details] [diff] [review]
Patch

Makes sense.

I don't have any ownership over /ipc so I don't feel qualified to "sign off" on changes to it.  But if you're just looking for a sanity-check/rubber-stamp, consider that granted. :)  I'll leave it to your judgement as to whether it's worth it to also r? someone who was involved with importing this code.  (probably unnecessary)

(Thanks for the link, too! Interesting to learn about that quirk of "inline" in C.)

Comment 2

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f179b135d4c

Rubber-stamp territory, seems to me.  :-)

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5f179b135d4c