Closed Bug 714445 Opened 8 years ago Closed 8 years ago

nsWebMReader::ReadMetadata reads preferences off the main thread

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox9 --- wontfix
firefox10 --- wontfix
firefox11 --- fixed

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch PatchSplinter Review
Which is not allowed.

I'm not sure if not setting mInfo.mStereoMode if the preference getter failed was intentional ... I'm going to guess it wasn't.
Attachment #585137 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/51965075faf5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 585137 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Bug 584259
User impact if declined: Potentially rare crashes when using WebM <video>
Testing completed (on m-c, etc.): None, but it's obvious from code inspection what's wrong here.
Risk to taking this patch (and alternatives if risky): Fairly low.
Attachment #585137 - Flags: approval-mozilla-beta?
Attachment #585137 - Flags: approval-mozilla-aurora?
Comment on attachment 585137 [details] [diff] [review]
Patch

[Triage Comment]
Let's take this on Aurora given the low risk nature of the fix, but let's only take on beta if we find that significant crash reports (right now we think it's rare).
Attachment #585137 - Flags: approval-mozilla-beta?
Attachment #585137 - Flags: approval-mozilla-beta-
Attachment #585137 - Flags: approval-mozilla-aurora?
Attachment #585137 - Flags: approval-mozilla-aurora+
Whiteboard: [qa-]
Depends on: 725152
No longer depends on: 744063
You need to log in before you can comment on or make changes to this bug.