use require('runtime') in system and xpcom modules

RESOLVED FIXED

Status

Add-on SDK
General
P5
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Erik Vold, Assigned: Erik Vold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Atm the system and xpcom modules are creating instances of nsIXULRuntime, but the runtime module already does this and exports all that these other two modules require.
(Assignee)

Updated

6 years ago
Assignee: nobody → erikvvold
Severity: normal → trivial
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P5
Hardware: x86 → All
(Assignee)

Comment 1

6 years ago
Created attachment 585156 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/314#

Pointer to Github pull-request
(Assignee)

Updated

6 years ago
Attachment #585156 - Flags: review?(rFobic)
(Assignee)

Updated

6 years ago
Attachment #585156 - Flags: review?(rFobic) → review?(myk)

Comment 2

6 years ago
Commit pushed to https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4d01e9f6ebeb50b4811715cc99c4b4623cb55012
Merge pull request #314 from erikvold/use-runtime

fix bug 714468 - using require('runtime') in system and xpcom modules; r=@mykmelez

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Attachment #585156 - Flags: review?(myk) → review+
You need to log in before you can comment on or make changes to this bug.