Viewpickerlabel has a white background on normal toolbars

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

12 Branch
Thunderbird 12.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird11 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 585194 [details]
Screenshot showing the issue

The viewpickerlabel has a white background to be better readable. Now with the tabs on top only the tabbar-toolbar is transparent. On other toolbars this background looks odd.
(Assignee)

Comment 1

6 years ago
Created attachment 585195 [details] [diff] [review]
Use the background only on tabbar-toolbar

This patch changes to show the white background only on the tabbar-toolbar. This is now the only transparent toolbar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #585195 - Flags: ui-review?(mconley)
Attachment #585195 - Flags: review?(mconley)
Comment on attachment 585195 [details] [diff] [review]
Use the background only on tabbar-toolbar

Fixes the problem for me, and the code looks good.  Thanks!

-Mike
Attachment #585195 - Flags: ui-review?(mconley)
Attachment #585195 - Flags: ui-review+
Attachment #585195 - Flags: review?(mconley)
Attachment #585195 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

6 years ago
Comment on attachment 585195 [details] [diff] [review]
Use the background only on tabbar-toolbar

Asking for approval because the same issue is on aurora
Attachment #585195 - Flags: approval-comm-aurora?

Updated

6 years ago
tracking-thunderbird11: --- → ?
(Assignee)

Updated

6 years ago
Duplicate of this bug: 715508
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3d61a0034ce1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #585195 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/83b039581185
status-thunderbird11: --- → fixed
tracking-thunderbird11: ? → ---
You need to log in before you can comment on or make changes to this bug.