714523 - editversions.cgi should use ->set_all

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Olav Vitters]

Attachment: Patch v1

Comment 1

[Frédéric Buclin]

Comment on attachment 585208 [details] [diff] [review]
Patch v1

Pushing this patch out of my radar till bug 714520 comment 1 is addressed. If your patch correctly works with VALIDATOR_DEPENDENCIES, please re-request review from me.

Comment 2

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v1

Comment 3

[Frédéric Buclin]

Comment on attachment 805035 [details] [diff] [review]
Patch-v1

>=== modified file 'Bugzilla/Version.pm'

>+sub set_value      { $_[0]->set('value', $_[1]);    }
>+sub set_isactive { $_[0]->set('isactive', $_[1]); }

Please fix the indentation.


> =item set_name

This method has been renamed set_value. So it doesn't pass tests anymore (011pod.t).



>=== modified file 'editversions.cgi'

>+        isactive=>  $isactive

Whitespace needed before =>.

Comment 4

[Sunil Joshi [:sjoshi]]

Attachment: Patch-v2

Comment 5

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified editversions.cgi
modified Bugzilla/Version.pm
Committed revision 8755.