Last Comment Bug 714556 - Port |Bug 644801 - Remove Native uconv from the tree| to comm-central
: Port |Bug 644801 - Remove Native uconv from the tree| to comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 12.0
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on: 644801
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-01 15:30 PST by Serge Gautherie (:sgautherie)
Modified: 2012-01-13 17:44 PST (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Remove Native uconv from the tree [Checked in: See comment 4] (4.91 KB, patch)
2012-01-11 21:52 PST, Serge Gautherie (:sgautherie)
standard8: review+
Details | Diff | Review

Description Serge Gautherie (:sgautherie) 2012-01-01 15:30:11 PST

    
Comment 1 Serge Gautherie (:sgautherie) 2012-01-11 21:52:02 PST
Created attachment 587952 [details] [diff] [review]
(Av1) Remove Native uconv from the tree
[Checked in: See comment 4]

mail/installer/removed-files.in:
I added this part per

(In reply to Makoto Kato from Bug 699009 comment #4)
> (In reply to Ed Morley [:edmorley] from comment #3)
> > Should components/ucnative.xpt go into removed files?
> 
> Native uconv was used by Minimo (for Windows mobile) and this build option
> wasn't used on Firefox/Thunderbird/SeaMonkey/Mozilla Suite.  I don't think
> we should add it to removed file.

Just tell me if TB prefers to keep it.
Comment 2 Serge Gautherie (:sgautherie) 2012-01-11 21:53:11 PST
> mail/installer/removed-files.in:

Ftr, it was added in bug 496683
http://hg.mozilla.org/comm-central/rev/1ba2d6e21cbf
Comment 3 Mark Banner (:standard8) 2012-01-13 06:06:06 PST
Comment on attachment 587952 [details] [diff] [review]
(Av1) Remove Native uconv from the tree
[Checked in: See comment 4]

>diff --git a/mail/installer/removed-files.in b/mail/installer/removed-files.in

>-  components/ucnative.xpt

I trust the notes based on what philor added, so please just leave this as-is.

r=me without that change.
Comment 4 Serge Gautherie (:sgautherie) 2012-01-13 17:42:43 PST
Comment on attachment 587952 [details] [diff] [review]
(Av1) Remove Native uconv from the tree
[Checked in: See comment 4]

http://hg.mozilla.org/comm-central/rev/459717882b5b
Av1, with comment 3 suggestion(s).

Note You need to log in before you can comment on or make changes to this bug.