The default bug view has changed. See this FAQ.

JS_ASSERT_IF prints extra parens on failure

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: Ms2ger)

Tracking

({regression})

Trunk
mozilla12
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Due to the patch in bug 712129, the failure in bug 709954 changed from

Assertion failure: !cx->isExceptionPending(), at js/src/jscntxtinlines.h:314

to

Assertion failure: (!cx->isExceptionPending()), at js/src/jscntxtinlines.h:314
I think I noticed it when reducing / bisecting bug 713944 too, which changed from:

Assertion failure: shape->writable(),

to:

Assertion failure: (shape->writable()),
(Assignee)

Comment 2

5 years ago
Created attachment 585263 [details] [diff] [review]
Patch v1

How about this?
Assignee: general → Ms2ger
Status: NEW → ASSIGNED
Attachment #585263 - Flags: review?(jwalden+bmo)
Comment on attachment 585263 [details] [diff] [review]
Patch v1

Review of attachment 585263 [details] [diff] [review]:
-----------------------------------------------------------------

Stupid macros.
Attachment #585263 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f301341f2e02

(In reply to Jeff Walden (remove +bmo to email) from comment #3)
> Stupid macros.

Indeed.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.