Closed
Bug 714580
Opened 12 years ago
Closed 12 years ago
JS_ASSERT_IF prints extra parens on failure
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jruderman, Assigned: Ms2ger)
References
Details
(Keywords: regression)
Attachments
(1 file)
810 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Due to the patch in bug 712129, the failure in bug 709954 changed from Assertion failure: !cx->isExceptionPending(), at js/src/jscntxtinlines.h:314 to Assertion failure: (!cx->isExceptionPending()), at js/src/jscntxtinlines.h:314
Comment 1•12 years ago
|
||
I think I noticed it when reducing / bisecting bug 713944 too, which changed from: Assertion failure: shape->writable(), to: Assertion failure: (shape->writable()),
Assignee | ||
Comment 2•12 years ago
|
||
How about this?
Comment 3•12 years ago
|
||
Comment on attachment 585263 [details] [diff] [review] Patch v1 Review of attachment 585263 [details] [diff] [review]: ----------------------------------------------------------------- Stupid macros.
Attachment #585263 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f301341f2e02 (In reply to Jeff Walden (remove +bmo to email) from comment #3) > Stupid macros. Indeed.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•