Closed Bug 714580 Opened 9 years ago Closed 9 years ago

JS_ASSERT_IF prints extra parens on failure

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jruderman, Assigned: Ms2ger)

References

Details

(Keywords: regression)

Attachments

(1 file)

Due to the patch in bug 712129, the failure in bug 709954 changed from

Assertion failure: !cx->isExceptionPending(), at js/src/jscntxtinlines.h:314

to

Assertion failure: (!cx->isExceptionPending()), at js/src/jscntxtinlines.h:314
I think I noticed it when reducing / bisecting bug 713944 too, which changed from:

Assertion failure: shape->writable(),

to:

Assertion failure: (shape->writable()),
Attached patch Patch v1Splinter Review
How about this?
Assignee: general → Ms2ger
Status: NEW → ASSIGNED
Attachment #585263 - Flags: review?(jwalden+bmo)
Comment on attachment 585263 [details] [diff] [review]
Patch v1

Review of attachment 585263 [details] [diff] [review]:
-----------------------------------------------------------------

Stupid macros.
Attachment #585263 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/f301341f2e02

(In reply to Jeff Walden (remove +bmo to email) from comment #3)
> Stupid macros.

Indeed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
OS: Mac OS X → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.