Last Comment Bug 714597 - GfxInfoCollector.h used in Thebes API depends on string internal api
: GfxInfoCollector.h used in Thebes API depends on string internal api
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: mozilla12
Assigned To: David Marteau
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2012-01-02 02:47 PST by David Marteau
Modified: 2012-01-04 04:41 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

gfxInfoCollector.patch (826 bytes, patch)
2012-01-02 02:47 PST, David Marteau
roc: review+
Details | Diff | Splinter Review

Description User image David Marteau 2012-01-02 02:47:51 PST
Created attachment 585264 [details] [diff] [review]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

Compile external binary xpcom component linking with xul library and using Thebes api.

Actual results:

Compilation failed because gfx/thebes/gfxPlatform.h include GfxInfoCollector.h which require MOZILLA_INTERNAL_API by using explicit reference to nsPromiseFlatString.(which is only defined for MOZILLA_INTERNAL_API).

Expected results:

Compilation should have succeeded because Thebes is defined as an exportable api for use in external components.

The proposed patch replace the the const ref to nsPromiseFlatString with a const ref to nsString which is a base class of nsPromiseFlatString and is compatible with the typedef for PromiseFlatString defined in nsStringAPI.h .
Comment 2 User image Marco Bonardo [::mak] 2012-01-04 04:41:47 PST

Note You need to log in before you can comment on or make changes to this bug.