714597 - GfxInfoCollector.h used in Thebes API depends on string internal api

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Marteau]

Attachment: gfxInfoCollector.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912

Steps to reproduce:

Compile external binary xpcom component linking with xul library and using Thebes api.



Actual results:

Compilation failed because gfx/thebes/gfxPlatform.h include GfxInfoCollector.h which require MOZILLA_INTERNAL_API by using explicit reference to nsPromiseFlatString.(which is only defined for MOZILLA_INTERNAL_API).



Expected results:

Compilation should have succeeded because Thebes is defined as an exportable api for use in external components.

The proposed patch replace the the const ref to nsPromiseFlatString with a const ref to nsString which is a base class of nsPromiseFlatString and is compatible with the typedef for PromiseFlatString defined in nsStringAPI.h .

Comment 1

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/93d49e745ff7

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/93d49e745ff7