Dead code in nsShiftJISToUnicode::Convert

RESOLVED FIXED in mozilla12

Status

()

Core
Internationalization
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 585277 [details] [diff] [review]
Patch v1

Both gCP932IndexShiftJis and gIBM943IndexShiftJis have only 0xFFFDs at the handled code points.
Attachment #585277 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #585277 - Flags: review? → review?(smontagu)
(Assignee)

Comment 1

6 years ago
Created attachment 585282 [details] [diff] [review]
Part b: simplify

And this can be simplified much more.
Attachment #585282 - Flags: review?(smontagu)
(Assignee)

Comment 2

6 years ago
Created attachment 585283 [details] [diff] [review]
Part b: simplify

And now the right way.
Attachment #585282 - Attachment is obsolete: true
Attachment #585282 - Flags: review?(smontagu)
Attachment #585283 - Flags: review?(smontagu)
Attachment #585277 - Flags: review?(smontagu) → review+
Comment on attachment 585283 [details] [diff] [review]
Part b: simplify

Review of attachment 585283 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, if you move the comment about "IE-compatible handling of undefined codepoints" and 5 following lines in front of the tables in japanese.map
Attachment #585283 - Flags: review?(smontagu) → review+
(Assignee)

Comment 4

6 years ago
Thanks!

https://hg.mozilla.org/mozilla-central/rev/e3cd4ae3e9e1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.