Closed
Bug 714613
Opened 13 years ago
Closed 13 years ago
Dead code in nsShiftJISToUnicode::Convert
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(2 files, 1 obsolete file)
|
1.70 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
|
7.73 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
Both gCP932IndexShiftJis and gIBM943IndexShiftJis have only 0xFFFDs at the handled code points.
Attachment #585277 -
Flags: review?
|
Assignee | |
Updated•13 years ago
|
Attachment #585277 -
Flags: review? → review?(smontagu)
|
|
Assignee | |
Comment 1•13 years ago
|
||
And this can be simplified much more.
Attachment #585282 -
Flags: review?(smontagu)
|
|
Assignee | |
Comment 2•13 years ago
|
||
And now the right way.
Attachment #585282 -
Attachment is obsolete: true
Attachment #585282 -
Flags: review?(smontagu)
Attachment #585283 -
Flags: review?(smontagu)
|
||
Updated•13 years ago
|
Attachment #585277 -
Flags: review?(smontagu) → review+
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 585283 [details] [diff] [review] Part b: simplify Review of attachment 585283 [details] [diff] [review]: ----------------------------------------------------------------- r=me, if you move the comment about "IE-compatible handling of undefined codepoints" and 5 following lines in front of the tables in japanese.map
Attachment #585283 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Thanks! https://hg.mozilla.org/mozilla-central/rev/e3cd4ae3e9e1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•