Dead code in nsShiftJISToUnicode::Convert

RESOLVED FIXED in mozilla12

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Posted patch Patch v1Splinter Review
Both gCP932IndexShiftJis and gIBM943IndexShiftJis have only 0xFFFDs at the handled code points.
Attachment #585277 - Flags: review?
Attachment #585277 - Flags: review? → review?(smontagu)
Posted patch Part b: simplify (obsolete) — Splinter Review
And this can be simplified much more.
Attachment #585282 - Flags: review?(smontagu)
And now the right way.
Attachment #585282 - Attachment is obsolete: true
Attachment #585282 - Flags: review?(smontagu)
Attachment #585283 - Flags: review?(smontagu)
Attachment #585277 - Flags: review?(smontagu) → review+
Comment on attachment 585283 [details] [diff] [review]
Part b: simplify

Review of attachment 585283 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, if you move the comment about "IE-compatible handling of undefined codepoints" and 5 following lines in front of the tables in japanese.map
Attachment #585283 - Flags: review?(smontagu) → review+
Thanks!

https://hg.mozilla.org/mozilla-central/rev/e3cd4ae3e9e1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.