Last Comment Bug 714613 - Dead code in nsShiftJISToUnicode::Convert
: Dead code in nsShiftJISToUnicode::Convert
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Makoto Kato [:m_kato]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-02 05:13 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-01-15 03:23 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.70 KB, patch)
2012-01-02 05:13 PST, :Ms2ger (⌚ UTC+1/+2)
smontagu: review+
Details | Diff | Splinter Review
Part b: simplify (8.09 KB, patch)
2012-01-02 06:31 PST, :Ms2ger (⌚ UTC+1/+2)
no flags Details | Diff | Splinter Review
Part b: simplify (7.73 KB, patch)
2012-01-02 06:46 PST, :Ms2ger (⌚ UTC+1/+2)
smontagu: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-01-02 05:13:15 PST
Created attachment 585277 [details] [diff] [review]
Patch v1

Both gCP932IndexShiftJis and gIBM943IndexShiftJis have only 0xFFFDs at the handled code points.
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-01-02 06:31:30 PST
Created attachment 585282 [details] [diff] [review]
Part b: simplify

And this can be simplified much more.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-01-02 06:46:08 PST
Created attachment 585283 [details] [diff] [review]
Part b: simplify

And now the right way.
Comment 3 Simon Montagu :smontagu 2012-01-11 09:33:10 PST
Comment on attachment 585283 [details] [diff] [review]
Part b: simplify

Review of attachment 585283 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, if you move the comment about "IE-compatible handling of undefined codepoints" and 5 following lines in front of the tables in japanese.map
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-01-15 03:23:37 PST
Thanks!

https://hg.mozilla.org/mozilla-central/rev/e3cd4ae3e9e1

Note You need to log in before you can comment on or make changes to this bug.