Closed
Bug 714646
Opened 13 years ago
Closed 13 years ago
jsgc.cpp fails to compile on Win64 GCC
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
1.21 KB,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
It fails because of cast from pointer to long, which loses precision on win64 and is an error by default on GCC. I've changed the code to use %p in JS_snprintf format, so that we don't need to cast anything.
Attachment #585294 -
Flags: review?
|
Assignee | |
Updated•13 years ago
|
Attachment #585294 -
Flags: review? → review?(igor)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 585294 [details] [diff] [review] fix v1.0 Review of attachment 585294 [details] [diff] [review]: ----------------------------------------------------------------- Nice trick of using %p :)
Attachment #585294 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Thanks for review, pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/8abe69741c4f
Whiteboard: [inbound]
|
||
Comment 3•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8abe69741c4f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•