Note: There are a few cases of duplicates in user autocompletion which are being worked on.

jsgc.cpp fails to compile on Win64 GCC

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla12
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 585294 [details] [diff] [review]
fix v1.0

It fails because of cast from pointer to long, which loses precision on win64 and is an error by default on GCC. I've changed the code to use %p in JS_snprintf format, so that we don't need to cast anything.
Attachment #585294 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #585294 - Flags: review? → review?(igor)

Comment 1

6 years ago
Comment on attachment 585294 [details] [diff] [review]
fix v1.0

Review of attachment 585294 [details] [diff] [review]:
-----------------------------------------------------------------

Nice trick of using %p :)
Attachment #585294 - Flags: review?(igor) → review+
(Assignee)

Comment 2

6 years ago
Thanks for review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8abe69741c4f
Whiteboard: [inbound]

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8abe69741c4f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.