714654 - [Collector] Allow installation of incompatible extensions in a collection when appropriate

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[Allan Gardner (:Mathnerd314)]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0a1) Gecko/20120102 Firefox/12.0a1
Build ID: 20120102031055

Steps to reproduce:

1. Get Nightly
2. Install Addon Compatibility Reporter
3. Install Addon Collector
4. Follow a collection with incompatible addons
5. Addon Manager -> Collection -> The collection


Actual results:

No way to install incompatible addons


Expected results:

Button saying "Install anyway"

Comment 1

[Allan Gardner (:Mathnerd314)]

I should have mentioned: the extensions are incompatible because their maxVersion fields are too low.

Comment 2

[David McNamara [:mackers]]

This bug is actually about supporting compat-by-default in the collector.

Support for compat-by-default in the collector has now been added in r99898.

All* "incompatible" add-ons can now be installed by the collector (regardless of whether ACR is installed).

* Except add-ons that:
- have maxVersion < 4.0 (or whatever extensions.minCompatibleAppVersion/extensions.minCompatiblePlatformVersion is set to)
- are not type = extension
- have binary components
- are on the blacklist
- have been individually marked as strictly compatible

Comment 3

[Brian King [:kinger]]

I did some light testing and everything seems to work as described in comment 2, but I have just one query:

(In reply to David McNamara [:mackers] from comment #2)
> All* "incompatible" add-ons can now be installed by the collector
> (regardless of whether ACR is installed).
> 
> * Except add-ons that:
> - have binary components

Can you point me to a collection that has such an add-on - not compatible with say beta or aurora and has a binary component.

Comment 4

[David McNamara [:mackers]]

(In reply to Brian King (Briks) [:kinger] from comment #3)
> Can you point me to a collection that has such an add-on - not compatible
> with say beta or aurora and has a binary component.

I can't find anything like this of the top of my head, but the binary part is an unknown to the collector.

Here is the implemented behaviour:

Add-on compatible with 4.0, without binary component: collector lists as installable, AOM allows installation.

Add-on compatible with 4.0, but with binary component: collector lists as installable, AOM blocks installation.