Closed Bug 714710 Opened 10 years ago Closed 10 years ago

LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(firefox11 fixed, firefox12 fixed, fennec11+)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

patch
1.00 KB, patch
dougt
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/LayerRenderer.java#328

Calling .run() doesn't actually start the Thread, so we are hurting the main thread IO

We should be calling start() here
Attached patch patch — — Splinter Review 
simple patch
Assignee: pwalton → mark.finkle
Attachment #585351 - Flags: review?(doug.turner)
Attachment #585351 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/03f3e1ebcd64
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585351 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Small chance of a the startup improvement, but mainly for correctness.
Attachment #585351 - Flags: approval-mozilla-aurora?
Comment on attachment 585351 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora given the possible perf improvement, otherwise this likely wouldn't meet the criteria for Aurora.
Attachment #585351 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.