Last Comment Bug 714710 - LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()
: LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()
Status: RESOLVED FIXED
:
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: x86 Linux
: P2 normal (vote)
: Firefox 12
Assigned To: Mark Finkle (:mfinkle) (use needinfo?)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-01-02 20:54 PST by Mark Finkle (:mfinkle) (use needinfo?)
Modified: 2012-01-06 22:13 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
fixed
fixed
11+

Attachments
patch (1.00 KB, patch)
2012-01-02 21:11 PST, Mark Finkle (:mfinkle) (use needinfo?) 		doug.turner: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Mark Finkle (:mfinkle) (use needinfo?) 2012-01-02 20:54:21 PST 
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/LayerRenderer.java#328

Calling .run() doesn't actually start the Thread, so we are hurting the main thread IO

We should be calling start() here
Comment 1 Mark Finkle (:mfinkle) (use needinfo?) 2012-01-02 21:11:18 PST 
Created attachment 585351 [details] [diff] [review]
patch

simple patch
Comment 2 Mark Finkle (:mfinkle) (use needinfo?) 2012-01-02 22:01:31 PST 
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f3e1ebcd64
Comment 3 Marco Bonardo [::mak] 2012-01-04 04:39:54 PST 
https://hg.mozilla.org/mozilla-central/rev/03f3e1ebcd64
Comment 4 Mark Finkle (:mfinkle) (use needinfo?) 2012-01-06 06:26:23 PST 
Comment on attachment 585351 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Small chance of a the startup improvement, but mainly for correctness.
Comment 5 Alex Keybl [:akeybl] 2012-01-06 11:06:45 PST 
Comment on attachment 585351 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora given the possible perf improvement, otherwise this likely wouldn't meet the criteria for Aurora.
Comment 6 Mark Finkle (:mfinkle) (use needinfo?) 2012-01-06 22:13:03 PST 
https://hg.mozilla.org/releases/mozilla-aurora/rev/11ed60b8dc20
Note You need to log in before you can comment on or make changes to this bug.