LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 12
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

Attachments

(1 attachment)

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/LayerRenderer.java#328

Calling .run() doesn't actually start the Thread, so we are hurting the main thread IO

We should be calling start() here
Created attachment 585351 [details] [diff] [review]
patch

simple patch
Assignee: pwalton → mark.finkle
Attachment #585351 - Flags: review?(doug.turner)

Updated

5 years ago
Attachment #585351 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f3e1ebcd64
https://hg.mozilla.org/mozilla-central/rev/03f3e1ebcd64
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585351 [details] [diff] [review]
patch

[Approval Request Comment]
Code cleanup. No risk

Small chance of a the startup improvement, but mainly for correctness.
Attachment #585351 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 585351 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approving for Aurora given the possible perf improvement, otherwise this likely wouldn't meet the criteria for Aurora.
Attachment #585351 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: --- → 11+
https://hg.mozilla.org/releases/mozilla-aurora/rev/11ed60b8dc20
status-firefox11: --- → fixed
status-firefox12: --- → fixed
You need to log in before you can comment on or make changes to this bug.