Closed
Bug 714710
Opened 9 years ago
Closed 9 years ago
LayerRenderer.checkFrameRateMonitorEnabled should use start() instead of run()
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox11 fixed, firefox12 fixed, fennec11+)
RESOLVED
FIXED
Firefox 12
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
1.00 KB,
patch
|
dougt
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/gfx/LayerRenderer.java#328 Calling .run() doesn't actually start the Thread, so we are hurting the main thread IO We should be calling start() here
Assignee | ||
Comment 1•9 years ago
|
||
simple patch
Assignee: pwalton → mark.finkle
Attachment #585351 -
Flags: review?(doug.turner)
Updated•9 years ago
|
Attachment #585351 -
Flags: review?(doug.turner) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03f3e1ebcd64
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03f3e1ebcd64
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 585351 [details] [diff] [review] patch [Approval Request Comment] Code cleanup. No risk Small chance of a the startup improvement, but mainly for correctness.
Attachment #585351 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Comment on attachment 585351 [details] [diff] [review] patch [Triage Comment] Mobile only - approving for Aurora given the possible perf improvement, otherwise this likely wouldn't meet the criteria for Aurora.
Attachment #585351 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
tracking-fennec: --- → 11+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/11ed60b8dc20
status-firefox11:
--- → fixed
status-firefox12:
--- → fixed
Updated•2 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•