714815 - Rewrite Builder Helper to remove deprecated legacy code and support SDK versions 1.4+

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P1)

Description

[Daniel Buchner [:dbuc]]

We need the ABH to be rewritten and simplified to rid the code of all the legacy work-arounds that were in play in the Firefox 4 beta series of releases. This rewrite should provide compatibility for the latest versions of the SDK (1.4+)

Additional goals:

- Ensure the ABH add-on calls the correct unload command sequence for accurate testing of add-ons by authors using the Builder.
- Upon install, the add-on(s) being tested should show up in all the normal user admin pages, this includes the Add-on Manager extension list.
- Allow for multiple add-ons to be installed at the same time.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 3

Link to the refactor/rewriting pull request

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 590669 [details]
Pull request 3

It's now ready for prime time! I end up splitting the main module in multiple ones.
So I've let 2 distinct commits: 
- one for the 1.4 refactoring, due to the new module loader and the vanishing of "development mode" and its related package,
- a second one where I split addon-builder-helper.js in multiple modules.

Finally, I had to avoid using Namespace because of garbage collection issue.
As private object is kept in a WeakMap, if nothing keep a reference to ou private attribute, it is automatically garbage collected and ends up being null.

Irakli: You can give a try to this addon by using this builder URL: 
https://builder-addons-dev.allizom.org/

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 590669 [details]
Pull request 3

I did a review, but not sure if I need to r+/- it, specially since it has been landed. I would still recommend implementing improvements suggested in the review, as it would make future maintenance easier. Also, I think doing those improvements in the follow up patch / bug is fine thing to do.

Comment 4

[Daniel Buchner [:dbuc]]

Moving the outstanding patch update request here to the next quarter as the current code in the new Builder Helper works for us.

Alex if you want to incorporate Irakli's changes feel free to do so, I will merge them in on Github and build a new version at that time.

Comment 5

[Alexandre Poirot [:ochameau]]

Landed and released looong time ago.