714840 - mirror_location_mirror_map id is growing too fast

Status: RESOLVED WORKSFORME

(Webtools :: Bouncer, defect)

Description

[Anthony Ricaud (:rik)]

On my local dump of the database, auto_increment is at 2 496 813 227 with only 1 057 255 rows. Something is deleting and creating rows like crazy and that will cause problem in the future (and already have see bug 585131).

Comment 1

[Fred Wenzel [:wenzel]]

Most likely, it's sentry:
https://github.com/fwenzel/tuxedo/blob/master/sentry/sentry.pl

However, at first sight, I can't tell what query in there would be deleting and recreating rows. Justdave, can you take a look? Perhaps I am just missing something. Thanks!

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Perhaps mirrors that flap on and offline according to sentry.

Comment 3

[Anthony Ricaud (:rik)]

I couldn't find something that deletes data either.

The most suspicious line I could find is https://github.com/fwenzel/tuxedo/blob/master/sentry/sentry.pl#L74 :
INSERT INTO mirror_location_mirror_map (location_id, mirror_id, active) VALUES (?, ?, ?) ON DUPLICATE KEY UPDATE active=VALUES(active)

But that shouldn't increment the primary key, unless there is a bug in MySQL that deletes and reinsert on duplicate key.

Comment 4

[Sheeri Cabral [:sheeri]]

potentially related to bug 943214? certainly potentially affected if we remove one of the unique keys....

Comment 5

[Sheeri Cabral [:sheeri]]

this bug, created 2 years ago, noted:
autoincremet of 
2,496,813,227 autoincrement
  1,057,255 rows

Checking, right now we're at:
2,498,586,718 autoincrement
  2,668,868 rows.

That's an increase of 1,773,491 in autoincrement, with an increase of 1,611,613 in rows.

I think whatever crazy rate of growth was happening, has been fixed. Marking this resolved unless you think it's something we should investigate further.