714842 - Increase caching on update.py

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Code Quality, defect, P5)

Description

[Andy McKay]

Currently we rely on Zeus to cache update pings, which caches something like 80% of the queries. That's great, but I bet we can cache more. 

We cache based on the query string, which means that two queries with extra paramaters like foo=bar and foo=baz will not be cached in Zeus and both do lookups. We could try adding in a memcache cache, maybe using amo.utils.memoize to cache the parameters we care about.

I'm not sure how much of a win this will be, the only hurt will be increased memcache traffic but for decreased mysql traffic.

Comment 1

[Wil Clouser [:clouserw]]

As long as it fails gracefully when memcache goes down, it wfm. :)

Comment 2

[Andy McKay]

Fortunately memcache never goes down. If it did, we'd be pooped.

Comment 3

[Wil Clouser [:clouserw]]

haven't heard any complaints here.  wontfixing.