Closed
Bug 71485
Opened 23 years ago
Closed 23 years ago
Convert bindingattached/detached to <constructor>/<destructor>
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9
People
(Reporter: hyatt, Assigned: hyatt)
Details
Attachments
(2 files)
43.46 KB,
patch
|
Details | Diff | Splinter Review | |
10.19 KB,
patch
|
Details | Diff | Splinter Review |
Switch 'em over.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Assignee | ||
Comment 1•23 years ago
|
||
Attaching patches. These include the patch to 71262.
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Comment 4•23 years ago
|
||
Nits: Indentation: Index: global/resources/content/colorpickerBindings.xml + <constructor><![CDATA[ + this.initialize(); + ]]></constructor> Index: global/resources/content/menulistBindings.xml <implementation> + <constructor> + this.setInitialSelection() + </constructor> Index: global/resources/content/tabBindings.xml <constructor/> uses tabs instead of spaces. Index: global/resources/content/toolbarBindings.xml + <constructor> this.init(event); - </handler> - </handlers> + </constructor> + </implementation> Index: global/resources/content/xulBindings.xml + <constructor action="var str = this.boxObject.getProperty('value'); + if (str) { + this.inputField.value=str; + this.boxObject.removeProperty('value'); + }"/> r=jag on both patches with a request to fix the indentation.
Comment 5•23 years ago
|
||
sr=hewitt on the xml part
Assignee | ||
Comment 6•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•