Closed Bug 71485 Opened 23 years ago Closed 23 years ago

Convert bindingattached/detached to <constructor>/<destructor>

Categories

(Core :: XUL, defect)

x86
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla0.9

People

(Reporter: hyatt, Assigned: hyatt)

Details

Attachments

(2 files)

Switch 'em over.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Attaching patches.  These include the patch to 71262.
Nits:

Indentation:

Index: global/resources/content/colorpickerBindings.xml
+         <constructor><![CDATA[
+        this.initialize();
+      ]]></constructor>

Index: global/resources/content/menulistBindings.xml
     <implementation>
+         <constructor>
+           this.setInitialSelection()
+         </constructor>

Index: global/resources/content/tabBindings.xml
<constructor/> uses tabs instead of spaces.

Index: global/resources/content/toolbarBindings.xml
+         <constructor>
         this.init(event);
-      </handler>
-    </handlers>
+      </constructor>
+    </implementation>

Index: global/resources/content/xulBindings.xml
+      <constructor action="var str = this.boxObject.getProperty('value'); 
+                                                if (str) {
+                                                  this.inputField.value=str;
+                                                 
this.boxObject.removeProperty('value');
+                                                }"/>

r=jag on both patches with a request to fix the indentation.
sr=hewitt on the xml part
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: