Convert bindingattached/detached to <constructor>/<destructor>

RESOLVED FIXED in mozilla0.9

Status

()

RESOLVED FIXED
18 years ago
10 years ago

People

(Reporter: hyatt, Assigned: hyatt)

Tracking

Trunk
mozilla0.9
x86
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

18 years ago
Switch 'em over.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 1

18 years ago
Attaching patches.  These include the patch to 71262.
(Assignee)

Comment 2

18 years ago
Created attachment 27321 [details] [diff] [review]
content DLL patch
(Assignee)

Comment 3

18 years ago
Created attachment 27322 [details] [diff] [review]
patch t o xbl files

Comment 4

18 years ago
Nits:

Indentation:

Index: global/resources/content/colorpickerBindings.xml
+         <constructor><![CDATA[
+        this.initialize();
+      ]]></constructor>

Index: global/resources/content/menulistBindings.xml
     <implementation>
+         <constructor>
+           this.setInitialSelection()
+         </constructor>

Index: global/resources/content/tabBindings.xml
<constructor/> uses tabs instead of spaces.

Index: global/resources/content/toolbarBindings.xml
+         <constructor>
         this.init(event);
-      </handler>
-    </handlers>
+      </constructor>
+    </implementation>

Index: global/resources/content/xulBindings.xml
+      <constructor action="var str = this.boxObject.getProperty('value'); 
+                                                if (str) {
+                                                  this.inputField.value=str;
+                                                 
this.boxObject.removeProperty('value');
+                                                }"/>

r=jag on both patches with a request to fix the indentation.

Comment 5

18 years ago
sr=hewitt on the xml part
(Assignee)

Comment 6

18 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.