Improve the error handling of print-manifest-dirs

NEW
Assigned to

Status

()

7 years ago
7 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Created attachment 585475 [details] [diff] [review]
Improve the error handling of print-manifest-dirs

Currently if we have parsing problems we just run into type errors. This makes print-manifest-dirs describe the problem better.
Attachment #585475 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 1

7 years ago
Created attachment 585479 [details] [diff] [review]
parse urls better

When we have HTTP, the paths that we have are urls and we should only use the path component instead of the whole url. This fixes the parsing of some of the reftests in image/test/reftest/encoders-lossless/reftest.list
Attachment #585479 - Flags: review?(ted.mielczarek)
Comment on attachment 585475 [details] [diff] [review]
Improve the error handling of print-manifest-dirs

Review of attachment 585475 [details] [diff] [review]:
-----------------------------------------------------------------

This feels like a messy way to handle the sitation. Instead, perhaps just set testURLs = None up before the if/else chain, and then you can do
if testURLs is None:
    <error>
Attachment #585475 - Flags: review?(ted.mielczarek) → review-
Attachment #585479 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → jmuizelaar
You need to log in before you can comment on or make changes to this bug.