WOO mailer busted by division by zero

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
There were 0 test runs recorded, due to a few bugs, for over a week.  This crashed the mailer when it tried to calculate the OF, dividing by zero.
(Assignee)

Comment 1

7 years ago
Created attachment 585506 [details] [diff] [review]
Fixed crash when missing test runs.

This fixes the crash when we get a test-run count of 0.  I also noticed that
the OF was being compared as a string, not a float as it should be, so I
fixed that too.
Attachment #585506 - Flags: review?(jgriffin)
Comment on attachment 585506 [details] [diff] [review]
Fixed crash when missing test runs.

Looks good!
Attachment #585506 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 3

7 years ago
Pushed as http://hg.mozilla.org/automation/orangefactor/rev/18be3cb316e0. Will be deployed along with bug 707197.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: Testing → Tree Management

Updated

4 years ago
Version: 12 Branch → unspecified
You need to log in before you can comment on or make changes to this bug.