Closed
Bug 714890
Opened 13 years ago
Closed 13 years ago
WOO mailer busted by division by zero
Categories
(Tree Management Graveyard :: OrangeFactor, defect)
Tree Management Graveyard
OrangeFactor
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned)
Details
Attachments
(1 file)
|
3.81 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
There were 0 test runs recorded, due to a few bugs, for over a week. This crashed the mailer when it tried to calculate the OF, dividing by zero.
|
Assignee | |
Comment 1•13 years ago
|
||
This fixes the crash when we get a test-run count of 0. I also noticed that the OF was being compared as a string, not a float as it should be, so I fixed that too.
Attachment #585506 -
Flags: review?(jgriffin)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 585506 [details] [diff] [review] Fixed crash when missing test runs. Looks good!
Attachment #585506 -
Flags: review?(jgriffin) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Pushed as http://hg.mozilla.org/automation/orangefactor/rev/18be3cb316e0. Will be deployed along with bug 707197.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Testing → Tree Management
|
||
Updated•10 years ago
|
Version: 12 Branch → unspecified
|
||
Updated•4 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•