getLanIp in devicemanager.py throws an exception on Mac OS X

RESOLVED FIXED in mozilla12

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

Trunk
mozilla12
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I'm trying to get the mochitests running on my machine locally, and the first roadblock I hit was that getLanIp was throwing a socket.gaierror exception. According to http://stackoverflow.com/a/7842004 this can be fixed by appending a ".local" to the hostname, and I have verified this works for me locally. Patch attached.

Not sure who should review this patch but sending request to jmaher to start; feel free to tag somebody else with the request.
Attachment #585492 - Flags: review?(jmaher)
Comment on attachment 585492 [details] [diff] [review]
Try with .local if hostname throws gaierror

Review of attachment 585492 [details] [diff] [review]:
-----------------------------------------------------------------

this seems like a pretty good fix.  Thanks for finding and fixing this.
Attachment #585492 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/cc4c6c59c516
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.