714965 - Change "setup" to "set up" in success message for pre-approval

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Log in to https://apps-preview-dev.allizom.org/en-US/apps/
2. Navigate to "Payment profile"
3. Set up PayPal pre-approval
4. On being redirected to 'payment Profile' page, notice the success message.

suggested changes to the success message:
a) change "set up" to "set up" in the success message- 'Pre-approval setup.'
b) make it more friendly by changing it to "Success! You have set up pre-approval for your account. Try purchasing an app now." (this verbose message probably needs sign off from fligtar)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #0)
> suggested changes to the success message:
> a) change "set up" to "set up" in the success message- 'Pre-approval setup.'

"Set up" is a verb. "Setup" is the correct noun.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> (In reply to krupa raj 82[:krupa] from comment #0)
> > suggested changes to the success message:
> > a) change "set up" to "set up" in the success message- 'Pre-approval setup.'
> 
> "Set up" is a verb. "Setup" is the correct noun.

cvan, this is an success message, not a heading.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #1)
> (In reply to krupa raj 82[:krupa] from comment #0)
> > suggested changes to the success message:
> > a) change "set up" to "set up" in the success message- 'Pre-approval setup.'
> 
> "Set up" is a verb. "Setup" is the correct noun.

cvan, this is a success message, not a heading.

Comment 4

[krupa raj[:krupa]]

(In reply to krupa raj 82[:krupa] from comment #0)

> 
> suggested changes to the success message:
> a) change "set up" to "set up" in the success message- 'Pre-approval setup.'

This should be: change "setup" to "set up". Sorry for the typo.

Comment 5

[Andy McKay]

https://github.com/mozilla/zamboni/commit/214c91

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/214c915