Closed
Bug 715022
Opened 13 years ago
Closed 13 years ago
Ensure that addonsManager.open waits until the selected view has been loaded
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [lib])
Attachments
(1 file)
|
3.67 KB,
patch
|
u279076
:
review+
|
Details | Diff | Splinter Review |
The failure of not having an add-on available after restarting Firefox (as seen on bug 670904) is caused by the addonsManager.open() method. Currently we do not wait until the currently selected view has been finished loading.
We have to do that if waitFor has been set.
| Assignee | ||
Comment 1•13 years ago
|
||
Adds an additional waitFor call for the ViewChanged event to happen. This will also fix the problem encountered on bug 670904.
Further I have fixed a comment we missed to update.
Attachment #585602 -
Flags: review?(anthony.s.hughes)
Attachment #585602 -
Flags: review?(anthony.s.hughes) → review+
Comment on attachment 585602 [details] [diff] [review]
Patch v1 [checked-in]
Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/a958a4854a3c (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/6a84a55e17b4 (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/a3553a5b8299 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/797d0b01cb83 (mozilla-release)
Attachment #585602 -
Attachment description: Patch v1 → Patch v1 [checked-in]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Given this has resulted in a couple dependencies being resolved, marking as VERIFIED.
Status: RESOLVED → VERIFIED
| Assignee | ||
Updated•13 years ago
|
Component: Mozmill Shared Modules → Mozmill Tests
| Assignee | ||
Updated•13 years ago
|
Whiteboard: [lib]
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•