The default bug view has changed. See this FAQ.

Pull updated Snappy revision (>=r56)

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
a month ago

People

(Reporter: Rogério Gonçalves, Assigned: Rogério Gonçalves)

Tracking

12 Branch
mozilla12
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
User Agent: Mozilla/5.0 (Ubuntu; X11; Linux i686; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111221215619

Steps to reproduce:

Compiling firefox nightly code with debug mode enabled (ac_add_options --enable-debug on mozconfig)
gcc-4.3.real (Ubuntu 4.3.5-3ubuntu1) 4.3.5
Ubuntu 10.10


Actual results:

/mozilla-central/other-licenses/snappy/src/snappy.cc:504: error: extra ‘;’
mozilla-central/other-licenses/snappy/src/snappy.cc:590: error: extra ‘;’



Expected results:

Finish the compilation process.
(Assignee)

Updated

5 years ago
Assignee: nobody → rogerio.rag
(Assignee)

Comment 1

5 years ago
Created attachment 585728 [details] [diff] [review]
Patch to this bug.
Attachment #585728 - Flags: review?
(Assignee)

Updated

5 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Component: General → DOM
Product: Firefox → Core
QA Contact: general → general
Attachment #585728 - Flags: review? → review?(bent.mozilla)
Comment on attachment 585728 [details] [diff] [review]
Patch to this bug.

Snappy is a library we pull from google, this issue needs to be reported to them:

https://code.google.com/p/snappy/issues/list
Attachment #585728 - Flags: review?(bent.mozilla)
(Assignee)

Comment 3

5 years ago
Ok.
I reported the error on the snappy site:
https://code.google.com/p/snappy/issues/detail?id=58
(Assignee)

Comment 4

5 years ago
The answer obtained on snappy issue:
--
Hi,

This is not an error in Snappy; it is not illegal C++, but it probably stops Firefox compile anyway due to -Werror. (I haven't checked that they actually compile with -Werror.) However, these warnings were already reported in  bug 57 , and the warning was fixed in r56.
--
https://code.google.com/p/snappy/source/detail?r=56
Re-summarizing the bug.
Summary: Error compiling with enabled debug mode in file snappy.cc → Pull updated Snappy revision (>=r56)
r56 seems to only fix one of the instances touched in Rogerio's patch.
Kyle tells me that we don't compile with -Werror... Are you using special compile flags? Or maybe WARNINGS_AS_ERRORS in your mozconfig?
Rogerio, do you have -Werror in your CFLAGS/CXXFLAGS in your environment?  As far as I can tell we shouldn't be building Snappy with -Werror by default.
(Assignee)

Comment 9

5 years ago
The content of my mozconfig:
  ac_add_options --enable-debug

Don't have WARNINGS_AS_ERRORS.

Environment vars CFLAGS/CXXFLAGS don't have -Werror.
(Assignee)

Comment 10

5 years ago
I checked out snappy code on mozilla-central/other-licenses/snappy/src (svn checkout http://snappy.googlecode.com/svn/trunk/ src)
The error doesn't occur on compiling process.
Ok, if pulling an updated upstream rev fixes it I don't care to worry about why it's broken.
Please make sure you follow the steps outlined in other-licenses/snappy/README too.
Created attachment 586069 [details] [diff] [review]
Update snappy to r56
Attachment #586069 - Flags: review?(bent.mozilla)
Yw.
Comment on attachment 586069 [details] [diff] [review]
Update snappy to r56

Looks fine, let's add the revision number and instructions to update it to README also.
Attachment #586069 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b0e65467c4c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
This was probably broken because we compile with -pedantic, FWIW. (I've hit the same problem with Breakpad code.)
Blocks: 768074
You need to log in before you can comment on or make changes to this bug.