Last Comment Bug 715162 - Move LazyIdleThread to XPCOM
: Move LazyIdleThread to XPCOM
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-04 09:02 PST by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2012-01-05 05:48 PST (History)
1 user (show)
khuey: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (7.15 KB, patch)
2012-01-04 09:02 PST, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
bent.mozilla: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-04 09:02:09 PST
Created attachment 585777 [details] [diff] [review]
Patch

There are uses for this before IDB, and xpcom/threads seems like a good shared home.
Comment 1 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-01-04 11:18:32 PST
Comment on attachment 585777 [details] [diff] [review]
Patch

Review of attachment 585777 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/LazyIdleThread.cpp
@@ +59,5 @@
>  #else
>  #define ASSERT_OWNING_THREAD() /* nothing */
>  #endif
>  
> +using mozilla::MutexAutoLock;

Nit: I think you can remove this.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-05 05:48:53 PST
https://hg.mozilla.org/mozilla-central/rev/2c8e6bd39c55

Note You need to log in before you can comment on or make changes to this bug.