Last Comment Bug 715185 - Remove 'using namespace mozilla::dom' from nsDOMFile.h
: Remove 'using namespace mozilla::dom' from nsDOMFile.h
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-04 09:46 PST by Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
Modified: 2012-01-05 05:49 PST (History)
2 users (show)
khuey: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.38 KB, patch)
2012-01-04 09:46 PST, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
mounir: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-04 09:46:15 PST
Created attachment 585791 [details] [diff] [review]
Patch

Using declarations in headers are bad.
Comment 1 Mounir Lamouri (:mounir) 2012-01-04 09:49:08 PST
Comment on attachment 585791 [details] [diff] [review]
Patch

Review of attachment 585791 [details] [diff] [review]:
-----------------------------------------------------------------

I guess no one is going to complain if I take this review :)
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-05 05:49:16 PST
https://hg.mozilla.org/mozilla-central/rev/f3e1f687b8f7

Note You need to log in before you can comment on or make changes to this bug.