glEGLImageTargetTexture2DOES shows error 501 frequently

RESOLVED FIXED in Firefox 11

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

unspecified
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is actually from other GL commands and not the one it is reporting. Should fix this up so at least it doesn't show bogus errors.
Attachment #585797 - Flags: review?(chrislord.net)
Attachment #585797 - Attachment is obsolete: true
Attachment #585797 - Flags: review?(chrislord.net)
Attachment #585798 - Flags: review?(chrislord.net)
Comment on attachment 585798 [details] [diff] [review]
Clear existing GL errors before trying to check for a new one

Review of attachment 585798 [details] [diff] [review]:
-----------------------------------------------------------------

Fine by me - I wonder if we want to have wrappers for GL commands though (I think gfx does this?) that will read and report errors automatically for debug builds, or something along those lines... But this can be addressed in a future patch.

Optionally, it'd be cool to have comments above the while loops, at least in the Java file, explaining why it's being done - something like "GL errors may have been encountered elsewhere, but we're only interested in those that occur here"
Attachment #585798 - Flags: review?(chrislord.net) → review+
I think there might be a debug EGLContext in Android that basically wraps everything and checks for errors. Maybe we should just add support for using that and ditch the specific error checking.

In the mean time I'll add the comment and check this in.
Landed on mozilla-central:

https://hg.mozilla.org/mozilla-central/rev/4d652a824f11
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 585798 [details] [diff] [review]
Clear existing GL errors before trying to check for a new one

[Triage Comment]
Attachment #585798 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.