715193 - Android should allow testing talos.zip changes through the try server

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Jeff Hammel]

http://armenzg.blogspot.com/2011/12/taloszip-talosjson-and-you.html is a great step forward in make Talos testable cross-platform.  However, :jmaher has pointed out that the android automation does not use this file for fetching Talos.  It should.  We currently have no staging environment that runs android :/

Comment 1

[Chris Cooper [:coop] (he/him)]

Armen: is this something you could take on? You deployed the other talos.json parts, and I don't think Android should be an afterthought here.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

the mobile stuff is very much out of band from desktop, this might not be a simple fix.

Comment 3

[Armen [:armenzg]]

It's completely different. IIRC the foopy checkouts the talos repo and the tegras grab it from there. Perhaps we could modify the foopy to checkout up to a given tag.

It can be independent of the talos.json or we could add a tag value inside of talos.json.

bear, aki: sounds doable?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Our workflow for talos and try is to run a set of changes we are planning on landing on try server before landing them.  So we would need to do something else other than "hg pull <tag>".

Comment 5

[Armen [:armenzg]]

hrmmm... you're right. I don't know much about the setup on the tegras. I'll have to learn!

Comment 6

[Armen [:armenzg]]

hehe I just saw that this was mentioned in the mobile testing notes.

https://wiki.mozilla.org/Mobile/Testing/01_25_12

So I guess it is important!

Comment 7

[cmtalbert]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #6)
> hehe I just saw that this was mentioned in the mobile testing notes.
> 
> https://wiki.mozilla.org/Mobile/Testing/01_25_12
> 
> So I guess it is important!

it's huge!

Comment 8

[Armen [:armenzg]]

I am giving higher priority to bug 723667.
I will get to this as soon as the other is on track to be fixed.

These are the two bugs that I am working on "P2".

Comment 9

[Armen [:armenzg]]

With http://hg.mozilla.org/build/buildbotcustom/rev/d65002e32e87 we are close to this since we already use the talos.zip.
It is now a matter to start using talos.json.

(unrelated work, I have to fix bug 734221 first)

Comment 10

[Armen [:armenzg]]

This is now my highest priority unless there is any follow up from bug 734221.

Comment 11

[Armen [:armenzg]]

A couple of days before I can work on this full on.

Comment 12

[Armen [:armenzg]]

Attachment: [untested] use talos_from_code.py to retrieve talos.zip

I wanted to extend talos_from_code.py and talos.json to download many other pieces but for now let's just focus on talos.zip and empower jhammel.

I will test this on Monday.

Comment 13

[Armen [:armenzg]]

It seems I need a python with simplejson on the foopies.

Comment 14

[Aki Sasaki (not active)]

I'm ok with installing simplejson if |import json| doesnt' work for you.
The foopies aren't puppetized iirc, so that'll take a csshX call or something.

Comment 15

[Armen [:armenzg]]

Attachment: [buildbotcustom] use talos_from_code.py to retrieve talos.zip

This has worked for me.
I modified the steps to be retrying and testing it once more on staging.

Nothing is needed to be deployed on the foopies since they have python 2.6 on them and the json module can be imported.

Comment 16

[Armen [:armenzg]]

Attachment: Match talos.zip from mobile and desktop

Carrying forward jmaher's review in bug 738685 to match mobile and desktop talos.zip in preparation for this buildbotcustom patch.

This could help us catch any discrepancies ahead of time.

http://hg.mozilla.org/integration/mozilla-inbound/rev/30bdb43d4a4a

Comment 17

[Armen [:armenzg]]

Specifically:
* mobile
http://hg.mozilla.org/build/buildbotcustom/file/tip/process/factory.py#l7730
> 7730 'http://build.mozilla.org/talos/zips/talos.bug738685.c08bb14e71cd.zip'],
and:
* desktop:
http://hg.mozilla.org/integration/mozilla-inbound/rev/30bdb43d4a4a#l1.7
> 1.6 -"url": "http://build.mozilla.org/talos/zips/talos.737117.8c0c35cac3e2.zip",
> 1.7 +"url": "http://build.mozilla.org/talos/zips/talos.bug738685.c08bb14e71cd.zip",

Comment 18

[Armen [:armenzg]]

Comment on attachment 609413 [details] [diff] [review]
[buildbotcustom] use talos_from_code.py to retrieve talos.zip

python /builds/tegra-022/talos-data/buildfarm/utils/retry.py -s 1 -r 5 -t 1260 wget --no-check-certificate http://hg.mozilla.org/mozilla-central/raw-file/8042c37b8100/testing/talos/talos_from_code.py

python /builds/tegra-022/talos-data/buildfarm/utils/retry.py -s 1 -r 5 -t 1260 /opt/local/bin/python talos_from_code.py --talos-json-url http://hg.mozilla.org/mozilla-central/raw-file/8042c37b8100/testing/talos/talos.json

Comment 19

[Aki Sasaki (not active)]

Comment on attachment 609413 [details] [diff] [review]
[buildbotcustom] use talos_from_code.py to retrieve talos.zip

>+        elif (platform.find("android") > -1):

I think we usually do |if 'android' in platform:| but this works too.

Looks good; does it work?

Comment 20

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/30bdb43d4a4a

Comment 21

[Armen [:armenzg]]

It does work. The string was tegra_android and I thought of making it general for when we have panda_android.

Comment 22

[Armen [:armenzg]]

Comment on attachment 609413 [details] [diff] [review]
[buildbotcustom] use talos_from_code.py to retrieve talos.zip

70e92b0482f4

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

this was deployed during a reconfig today

Comment 24

[Armen [:armenzg]]

I filed bug 739721 to deal with other changes that can make use of talos.json

With regards to talos.zip we are done.

Comment 25

[Armen [:armenzg]]

It seems we broke this for mozilla-esr10. Patch coming.

Comment 26

[Armen [:armenzg]]

Attachment: [buildbotcustom] use talos.json method if talos_from_source_code is enabled

Still waiting to see a passing run on staging before asking for review.

Comment 27

[Armen [:armenzg]]

FTR, this is the problem:

python /builds/tegra-234/talos-data/buildfarm/utils/retry.py -s 1 -r 5 -t 1260 wget --no-check-certificate http://hg.mozilla.org/releases/mozilla-esr10/raw-file/578cf13bf0cb/testing/talos/talos_from_code.py
 in dir /builds/tegra-234/test/../talos-data (timeout 1320 secs)
 watching logfiles {}
 argv: ['python', '/builds/tegra-234/talos-data/buildfarm/utils/retry.py', '-s', '1', '-r', '5', '-t', '1260', 'wget', '--no-check-certificate', 'http://hg.mozilla.org/releases/mozilla-esr10/raw-file/578cf13bf0cb/testing/talos/talos_from_code.py']
 environment:
  PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PWD=/builds/tegra-234/talos-data
  SUT_IP=10.250.51.74
  SUT_NAME=tegra-234
  __CF_USER_TEXT_ENCODING=0x1F5:0:0
 closing stdin
 using PTY: False
retry: Calling <function run_with_timeout at 0x10c84fe60> with args: (['wget', '--no-check-certificate', 'http://hg.mozilla.org/releases/mozilla-esr10/raw-file/578cf13bf0cb/testing/talos/talos_from_code.py'], 1260, None, None, False, True), kwargs: {}, attempt #1
Executing: ['wget', '--no-check-certificate', 'http://hg.mozilla.org/releases/mozilla-esr10/raw-file/578cf13bf0cb/testing/talos/talos_from_code.py']
--2012-03-28 12:11:37--  http://hg.mozilla.org/releases/mozilla-esr10/raw-file/578cf13bf0cb/testing/talos/talos_from_code.py
Resolving hg.mozilla.org (hg.mozilla.org)... 10.2.74.153
Connecting to hg.mozilla.org (hg.mozilla.org)|10.2.74.153|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2012-03-28 12:11:44 ERROR 404: Not Found.

Comment 28

[Armen [:armenzg]]

Comment on attachment 610273 [details] [diff] [review]
[buildbotcustom] use talos.json method if talos_from_source_code is enabled

It looks good on staging.

Comment 29

[Aki Sasaki (not active)]

Comment on attachment 610273 [details] [diff] [review]
[buildbotcustom] use talos.json method if talos_from_source_code is enabled

>+            else:
>+                self.addStep(RetryingShellCommand(
>+                 name='get_talos_zip',
>+                 command=['wget', '-O', 'talos.zip', '--no-check-certificate',
>+                          'http://build.mozilla.org/talos/zips/talos.bug738685.c08bb14e71cd.zip'],

For this else, wouldn't it be easier to point at a known-named softlink?
If we're planning on only needing this fallback for a very short amount of time, this is fine, otherwise the known-named softlink would help us deploy new talos zips (manually) without a reconfig.

Comment 30

[Phil Ringnalda (:philor)]

esr-10 is closed.

Comment 31

[Armen [:armenzg]]

I will deploy it now.

Comment 32

[Armen [:armenzg]]

Comment on attachment 610273 [details] [diff] [review]
[buildbotcustom] use talos.json method if talos_from_source_code is enabled

I added a talos.mobile.old.zip symlink. This is needed for old branches like esr10 and 1.9.2.

http://hg.mozilla.org/build/buildbotcustom/rev/158a3faf1adf

I have reconfigured and I am now triggering the jobs.

Comment 33

[Armen [:armenzg]]

I don't know what's going on. remotePerfConfigurator.py is failing:

> python remotePerfConfigurator.py -v -e org.mozilla.firefox -t tegra-152 --branchName Mozilla-Esr10 --resultsServer graphs.mozilla.org --resultsLink /server/collect.cgi --activeTests tsspider --noChrome --symbolsPath ../symbols --remoteDevice 10.250.50.62 --sampleConfig remote.config --output local.yml --webServer bm-remote.build.mozilla.org --browserWait 60
> remotePerfConfigurator.py: ERROR: Unable to connect to remote device '10.250.51.87'

https://tbpl.mozilla.org/php/getParsedLog.php?id=10472433&tree=Mozilla-Esr10&full=1

Comment 34

[Armen [:armenzg]]

I see green.
https://tbpl.mozilla.org/php/getParsedLog.php?id=10473964&tree=Mozilla-Esr10&full=1

I changed the symlink to the latest talos.zip to fix comment 33 as per jmaher's suggestion (the previous talos.zip was a bad one I chose).