Closed
Bug 715197
Opened 14 years ago
Closed 14 years ago
Robocop: FennecNativeElement.isDisplayed is not implemented
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Current implementation of FennecNativeElement.isDisplayed:
@Override
public boolean isDisplayed() {
// TODO Auto-generated method stub
return false;
}
This is not currently used, but seems like it could be useful.
|
Assignee | |
Comment 1•14 years ago
|
||
Straight-forward implementation that mirrors the code in click() and getText(), so that isDisplayed() can be read as "is it safe to click/access this element right now?"
Attachment #585920 -
Flags: review?(jmaher)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 585920 [details] [diff] [review]
patch to implement isDisplayed()
Review of attachment 585920 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/mobile/robocop/FennecNativeElement.java.in
@@ +160,5 @@
> + });
> + try {
> + syncQueue.take();
> + } catch (InterruptedException e) {
> + e.printStackTrace();
I am thinking we should do better file logging vs just printing a stack trace, but that could be saved for an overall cleanup for the entire robocop toolchain.
Attachment #585920 -
Flags: review?(jmaher) → review+
|
|
||
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•