Closed Bug 715197 Opened 9 years ago Closed 9 years ago

Robocop: FennecNativeElement.isDisplayed is not implemented

Categories

(Testing :: General, defect)

x86
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

Current implementation of FennecNativeElement.isDisplayed:

@Override
public boolean isDisplayed() {
  // TODO Auto-generated method stub
  return false;
}

This is not currently used, but seems like it could be useful.
Straight-forward implementation that mirrors the code in click() and getText(), so that isDisplayed() can be read as "is it safe to click/access this element right now?"
Attachment #585920 - Flags: review?(jmaher)
Comment on attachment 585920 [details] [diff] [review]
patch to implement isDisplayed()

Review of attachment 585920 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/robocop/FennecNativeElement.java.in
@@ +160,5 @@
> +        });
> +    try {
> +      syncQueue.take();
> +    } catch (InterruptedException e) {
> +      e.printStackTrace();

I am thinking we should do better file logging vs just printing a stack trace, but that could be saved for an overall cleanup for the entire robocop toolchain.
Attachment #585920 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/e20434400f0c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.