Customize toolbar dialog buttons are strangely tall

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: Paenglab)

Tracking

12 Branch
Thunderbird 12.0
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Created attachment 585815 [details]
Tall toolbar buttons in the Customize Toolbar window

I just noticed this on trunk - is anybody else seeing it?  See attachment.
(Assignee)

Comment 1

5 years ago
I'm seeing this too. Firefox don't showing the buttons and with this in primaryToolbar.css

#palette-box .toolbarbutton-1 {
  border: none;
  background: none;
}

the problem with the tall buttons is gone because also no buttons are shown.

Would this approach be okay?
Paenglab:

If it's what Firefox is doing, it's probably the right course of action.  So, yes, that approach gets my thumbs-up. :)

-Mike
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 585833 [details] [diff] [review]
Remove the button appearance

This patch removes the button appearance and shows only the icons like Firefox does.
The patch is a bit bigger as noted in comment 1 because also the QFB button imitation is removed.
Attachment #585833 - Flags: ui-review?(bwinton)
Attachment #585833 - Flags: review?(mconley)
Richard:

Hm - so, this looks pretty good for the stock Customize buttons, but I notice that the Quick Filter button still has the look if I drag it into the customize window.

See attachment.

-Mike
Created attachment 586153 [details]
The Quick Filter button still looks button-y

Comment 6

5 years ago
(In reply to Mike Conley (:mconley) from comment #4)
> Hm - so, this looks pretty good for the stock Customize buttons, but I
> notice that the Quick Filter button still has the look if I drag it into the
> customize window.

I bet this will be fixed by bug 633679.
squib:

I think you're right - manually applying the toolbarbutton-1 class to the QFB was all we needed to do there.

So I'll ignore that little blip, and continue my review...

-Mike
Comment on attachment 585833 [details] [diff] [review]
Remove the button appearance

Code looks good, and I'm also liking how our customization dialog matches Firefox more.  Stealing the ui-r from bwinton, and givin' this patch a big ol' plus.
Attachment #585833 - Flags: ui-review?(bwinton)
Attachment #585833 - Flags: ui-review+
Attachment #585833 - Flags: review?(mconley)
Attachment #585833 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/4aba635a2e77
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.