Last Comment Bug 715212 - Customize toolbar dialog buttons are strangely tall
: Customize toolbar dialog buttons are strangely tall
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: 12 Branch
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 12.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-04 10:52 PST by Mike Conley (:mconley)
Modified: 2012-01-05 13:59 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Tall toolbar buttons in the Customize Toolbar window (46.17 KB, image/png)
2012-01-04 10:52 PST, Mike Conley (:mconley)
no flags Details
Remove the button appearance (1.23 KB, patch)
2012-01-04 11:48 PST, Richard Marti (:Paenglab)
mconley: review+
mconley: ui‑review+
Details | Diff | Splinter Review
The Quick Filter button still looks button-y (48.50 KB, image/png)
2012-01-05 11:20 PST, Mike Conley (:mconley)
no flags Details

Description Mike Conley (:mconley) 2012-01-04 10:52:45 PST
Created attachment 585815 [details]
Tall toolbar buttons in the Customize Toolbar window

I just noticed this on trunk - is anybody else seeing it?  See attachment.
Comment 1 Richard Marti (:Paenglab) 2012-01-04 11:07:33 PST
I'm seeing this too. Firefox don't showing the buttons and with this in primaryToolbar.css

#palette-box .toolbarbutton-1 {
  border: none;
  background: none;
}

the problem with the tall buttons is gone because also no buttons are shown.

Would this approach be okay?
Comment 2 Mike Conley (:mconley) 2012-01-04 11:11:37 PST
Paenglab:

If it's what Firefox is doing, it's probably the right course of action.  So, yes, that approach gets my thumbs-up. :)

-Mike
Comment 3 Richard Marti (:Paenglab) 2012-01-04 11:48:37 PST
Created attachment 585833 [details] [diff] [review]
Remove the button appearance

This patch removes the button appearance and shows only the icons like Firefox does.
The patch is a bit bigger as noted in comment 1 because also the QFB button imitation is removed.
Comment 4 Mike Conley (:mconley) 2012-01-05 11:19:55 PST
Richard:

Hm - so, this looks pretty good for the stock Customize buttons, but I notice that the Quick Filter button still has the look if I drag it into the customize window.

See attachment.

-Mike
Comment 5 Mike Conley (:mconley) 2012-01-05 11:20:28 PST
Created attachment 586153 [details]
The Quick Filter button still looks button-y
Comment 6 Jim Porter (:squib) 2012-01-05 11:25:07 PST
(In reply to Mike Conley (:mconley) from comment #4)
> Hm - so, this looks pretty good for the stock Customize buttons, but I
> notice that the Quick Filter button still has the look if I drag it into the
> customize window.

I bet this will be fixed by bug 633679.
Comment 7 Mike Conley (:mconley) 2012-01-05 11:46:05 PST
squib:

I think you're right - manually applying the toolbarbutton-1 class to the QFB was all we needed to do there.

So I'll ignore that little blip, and continue my review...

-Mike
Comment 8 Mike Conley (:mconley) 2012-01-05 11:51:54 PST
Comment on attachment 585833 [details] [diff] [review]
Remove the button appearance

Code looks good, and I'm also liking how our customization dialog matches Firefox more.  Stealing the ui-r from bwinton, and givin' this patch a big ol' plus.
Comment 9 Mike Conley (:mconley) 2012-01-05 13:59:22 PST
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/4aba635a2e77

Note You need to log in before you can comment on or make changes to this bug.