Closed
Bug 715212
Opened 11 years ago
Closed 11 years ago
Customize toolbar dialog buttons are strangely tall
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 12.0
People
(Reporter: mconley, Assigned: Paenglab)
Details
Attachments
(3 files)
46.17 KB,
image/png
|
Details | |
1.23 KB,
patch
|
mconley
:
review+
mconley
:
ui-review+
|
Details | Diff | Splinter Review |
48.50 KB,
image/png
|
Details |
I just noticed this on trunk - is anybody else seeing it? See attachment.
Assignee | ||
Comment 1•11 years ago
|
||
I'm seeing this too. Firefox don't showing the buttons and with this in primaryToolbar.css #palette-box .toolbarbutton-1 { border: none; background: none; } the problem with the tall buttons is gone because also no buttons are shown. Would this approach be okay?
Reporter | ||
Comment 2•11 years ago
|
||
Paenglab: If it's what Firefox is doing, it's probably the right course of action. So, yes, that approach gets my thumbs-up. :) -Mike
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
This patch removes the button appearance and shows only the icons like Firefox does. The patch is a bit bigger as noted in comment 1 because also the QFB button imitation is removed.
Attachment #585833 -
Flags: ui-review?(bwinton)
Attachment #585833 -
Flags: review?(mconley)
Reporter | ||
Comment 4•11 years ago
|
||
Richard: Hm - so, this looks pretty good for the stock Customize buttons, but I notice that the Quick Filter button still has the look if I drag it into the customize window. See attachment. -Mike
Reporter | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
(In reply to Mike Conley (:mconley) from comment #4) > Hm - so, this looks pretty good for the stock Customize buttons, but I > notice that the Quick Filter button still has the look if I drag it into the > customize window. I bet this will be fixed by bug 633679.
Reporter | ||
Comment 7•11 years ago
|
||
squib: I think you're right - manually applying the toolbarbutton-1 class to the QFB was all we needed to do there. So I'll ignore that little blip, and continue my review... -Mike
Reporter | ||
Comment 8•11 years ago
|
||
Comment on attachment 585833 [details] [diff] [review] Remove the button appearance Code looks good, and I'm also liking how our customization dialog matches Firefox more. Stealing the ui-r from bwinton, and givin' this patch a big ol' plus.
Attachment #585833 -
Flags: ui-review?(bwinton)
Attachment #585833 -
Flags: ui-review+
Attachment #585833 -
Flags: review?(mconley)
Attachment #585833 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 9•11 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/4aba635a2e77
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in
before you can comment on or make changes to this bug.
Description
•