715212 - Customize toolbar dialog buttons are strangely tall

Status: RESOLVED FIXED

Description

[Mike Conley (:mconley) (:⚙️)]

Created attachment 585815 [details]
Tall toolbar buttons in the Customize Toolbar window

I just noticed this on trunk - is anybody else seeing it?  See attachment.

Comment 1

[Richard Marti (:Paenglab)]

I'm seeing this too. Firefox don't showing the buttons and with this in primaryToolbar.css

#palette-box .toolbarbutton-1 {
  border: none;
  background: none;
}

the problem with the tall buttons is gone because also no buttons are shown.

Would this approach be okay?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Paenglab:

If it's what Firefox is doing, it's probably the right course of action.  So, yes, that approach gets my thumbs-up. :)

-Mike

Comment 3

[Richard Marti (:Paenglab)]

Created attachment 585833 [details] [diff] [review]
Remove the button appearance

This patch removes the button appearance and shows only the icons like Firefox does.
The patch is a bit bigger as noted in comment 1 because also the QFB button imitation is removed.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Richard:

Hm - so, this looks pretty good for the stock Customize buttons, but I notice that the Quick Filter button still has the look if I drag it into the customize window.

See attachment.

-Mike

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Created attachment 586153 [details]
The Quick Filter button still looks button-y

Comment 6

[Jim Porter (:squib)]

(In reply to Mike Conley (:mconley) from comment #4)
> Hm - so, this looks pretty good for the stock Customize buttons, but I
> notice that the Quick Filter button still has the look if I drag it into the
> customize window.

I bet this will be fixed by bug 633679.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

squib:

I think you're right - manually applying the toolbarbutton-1 class to the QFB was all we needed to do there.

So I'll ignore that little blip, and continue my review...

-Mike

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 585833 [details] [diff] [review]
Remove the button appearance

Code looks good, and I'm also liking how our customization dialog matches Firefox more.  Stealing the ui-r from bwinton, and givin' this patch a big ol' plus.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/4aba635a2e77