Closed Bug 715303 Opened 8 years ago Closed 8 years ago

No focus on select when tapping on selects

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
fennec 11+ ---

People

(Reporter: martijn.martijn, Assigned: wesj)

Details

(Keywords: testcase)

Attachments

(3 files)

Attached file testcase
See testcase, when tapping on the selects, a focus event should fire.
This works fine in XUL Fennec and stock browser, but Fennec Native doesn't give focus to the select.
Assignee: nobody → wjohnston
Attached patch PatchSplinter Review
Hmm... looks like we manually fired this in XUL Fennec right before sending a message to show the UI:

http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/forms.js#203

I'm only doing this for select elements for now here. The form assistant gets sent taps on all sorts of elements to determine if it needs to help, so we don't want to always call focus.
Attachment #586179 - Flags: review?(mark.finkle)
Attachment #586179 - Flags: review?(mark.finkle) → review+
Attached file testcase2
Sorry, I should have been more clear.
Not only, no focus events are fired, but I don't see any of the mouse events either.

See testcase, ideally, when tapping on the select, the same events as on the link should fire, namely:
mousemove
mousedown
focus
mouseup
click
And they also should fire in that order.
I'll have to play a bit. We actually don't want clicks to fire on the select elements, as the selected item shouldn't change when you tap on multirow selects in mobile. But maybe there's some trickery we did before to fire click with some other target.
See the patch in bug 685197 for the trickery I used in XUL Fennec, especially the css part.
Priority: -- → P2
tracking-fennec: --- → 11+
https://hg.mozilla.org/mozilla-central/rev/309fc0271e4c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 586179 [details] [diff] [review]
Patch

[Approval Request Comment]
Caused by the new Native code. This fix gets Fennec back to XUL Fennec compat.
Attachment #586179 - Flags: approval-mozilla-aurora?
Comment on attachment 586179 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #586179 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:11.0a2)Gecko/20120130
Firefox/11.0a2 Fennec/11.0a2
Device: Samsung Galaxy S
OS: Android 2.2

Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20120130
Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.