mochitests will hang if previous test run didn't clean up

RESOLVED FIXED in mozilla12

Status

Testing
Mochitest
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: blassey, Assigned: gbrown)

Tracking

12 Branch
mozilla12
x86
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR:
1) run mochitests
2) ctrl+C
3) run mochitests

ER:
mochitests run

AR:
mochitests hang
(Assignee)

Comment 1

6 years ago
blassey is talking about mochitest-remote here. We found that manually deleting the profile from the device got things working again.

runtests.py::runTests() calls runtestsremote.py::cleanup() which deletes the remote profile. But the cleanup() call is at the end of the test run. When ctrl+C is used to break out of a run, presumably this is not called. 

Maybe the profile directory could be deleted on startup instead of, or in addition to, on shutdown? Or we could handle ctrl+C better perhaps....
(Assignee)

Updated

6 years ago
Assignee: nobody → gbrown
OS: Mac OS X → Android
(Assignee)

Comment 2

6 years ago
Created attachment 585971 [details] [diff] [review]
patch to delete remote profile before pushing a new one

I am hopeful this very simple change will work, but haven't tested it yet.
this seems pretty harmless and a good safe guard.
(Assignee)

Comment 4

6 years ago
Works fine for me locally. 

Also pushed to try:

https://tbpl.mozilla.org/?tree=Try&rev=f9cbab998894
(Assignee)

Updated

6 years ago
Attachment #585971 - Flags: review?(jmaher)
Comment on attachment 585971 [details] [diff] [review]
patch to delete remote profile before pushing a new one

Review of attachment 585971 [details] [diff] [review]:
-----------------------------------------------------------------

looks very harmless, try server will be my best friend here.
Attachment #585971 - Flags: review?(jmaher) → review+
inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8c8e768e9f
https://hg.mozilla.org/mozilla-central/rev/fa8c8e768e9f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.