Robocop: fennec native tests need cleanup

RESOLVED FIXED in mozilla12

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla12
x86
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: not-fennec-11)

Attachments

(2 attachments, 1 obsolete attachment)

Lots of duplicated code in the actual test files that can be factored out and cleaned up. Patches forthcoming.
Oops, uploaded wrong patch
Attachment #585998 - Attachment is obsolete: true
Attachment #585998 - Flags: review?(jmaher)
Attachment #585999 - Flags: review?(jmaher)
Attachment #585997 - Flags: review?(jmaher) → review+
Comment on attachment 585999 [details] [diff] [review]
(2/2) Factor out more utility functions into BaseTest

Review of attachment 585999 [details] [diff] [review]:
-----------------------------------------------------------------

my only thoughts are BaseTest might grow large with support functions, we might want to consider making a utility class or something if it gets too large.
Attachment #585999 - Flags: review?(jmaher) → review+
> my only thoughts are BaseTest might grow large with support functions, we
> might want to consider making a utility class or something if it gets too
> large.

True. My preferred approach in that situation would be to add additional layers to the class hierarchy; so if there are a group of tests that need a particular set of support functions (e.g. framerate monitoring) create another abstract subclass of BaseTest (FrameRateTest) with those functions and then have that set of tests derive from that.
https://hg.mozilla.org/mozilla-central/rev/262123f588e0
https://hg.mozilla.org/mozilla-central/rev/e4c773d0f228
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Whiteboard: not-fennec-11
You need to log in before you can comment on or make changes to this bug.