715443 - Robocop: fennec native tests need cleanup

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Lots of duplicated code in the actual test files that can be factored out and cleaned up. Patches forthcoming.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Factor out a BaseTest class and do misc cleanups

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Factor out more utility functions into BaseTest

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Factor out more utility functions into BaseTest

Oops, uploaded wrong patch

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 585999 [details] [diff] [review]
(2/2) Factor out more utility functions into BaseTest

Review of attachment 585999 [details] [diff] [review]:
-----------------------------------------------------------------

my only thoughts are BaseTest might grow large with support functions, we might want to consider making a utility class or something if it gets too large.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

> my only thoughts are BaseTest might grow large with support functions, we
> might want to consider making a utility class or something if it gets too
> large.

True. My preferred approach in that situation would be to add additional layers to the class hierarchy; so if there are a group of tests that need a particular set of support functions (e.g. framerate monitoring) create another abstract subclass of BaseTest (FrameRateTest) with those functions and then have that set of tests derive from that.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/262123f588e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4c773d0f228

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/262123f588e0
https://hg.mozilla.org/mozilla-central/rev/e4c773d0f228