Last Comment Bug 715495 - Inconsistency in styling of buttons in tabs-toolbar
: Inconsistency in styling of buttons in tabs-toolbar
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: 11 Branch
: x86 Windows 7
: -- normal (vote)
: Thunderbird 12.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on: 721249
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 07:37 PST by Andreas Nilsson (:andreasn)
Modified: 2012-01-25 15:53 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Thunderbird on top, Firefox on bottom (7.53 KB, image/png)
2012-01-05 07:37 PST, Andreas Nilsson (:andreasn)
no flags Details
patch v1 - icons (wip) (9.37 KB, patch)
2012-01-05 18:11 PST, Andreas Nilsson (:andreasn)
no flags Details | Diff | Splinter Review
Firefox-style on tabbar-toolbar (8.95 KB, patch)
2012-01-06 14:36 PST, Richard Marti (:Paenglab)
no flags Details | Diff | Splinter Review
Firefox-style on tabbar-toolbar v2 (10.90 KB, patch)
2012-01-07 06:39 PST, Richard Marti (:Paenglab)
bugs: ui‑review-
Details | Diff | Splinter Review
screenshot (38.65 KB, image/png)
2012-01-08 09:35 PST, Andreas Nilsson (:andreasn)
no flags Details
New patch with updated icons (12.88 KB, patch)
2012-01-10 07:49 PST, Andreas Nilsson (:andreasn)
bugs: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
above patch in action (28.51 KB, image/png)
2012-01-10 07:53 PST, Andreas Nilsson (:andreasn)
no flags Details

Description Andreas Nilsson (:andreasn) 2012-01-05 07:37:40 PST
Created attachment 586067 [details]
Thunderbird on top, Firefox on bottom

It seems we have at least three different ways we style buttons in the tabs-toolbar area on Aero (the area below the window controls). Either as heavier buttons (quicksearch), full color icons (calendar/todo) or white icons with a black outline (tabs dropdown).
Firefox styles all these items as in the last example. I think we should do that too.
Comment 1 Andreas Nilsson (:andreasn) 2012-01-05 18:11:39 PST
Created attachment 586299 [details] [diff] [review]
patch v1 - icons (wip)

This is the icons part of the patch, no css yet. Probably tomorrow.
Comment 2 Richard Marti (:Paenglab) 2012-01-06 14:36:09 PST
Created attachment 586572 [details] [diff] [review]
Firefox-style on tabbar-toolbar

On the tabbar-toolbar the icons are now inverted and the buttons have the All-tabs button styling on hover and checked (like Firefox).

I haven't gave special styles to the QFB button because Bug 633679 will change it to a standard toolbarbutton-1 which makes additional styling needless.
Comment 3 Richard Marti (:Paenglab) 2012-01-07 06:39:19 PST
Created attachment 586666 [details] [diff] [review]
Firefox-style on tabbar-toolbar v2

Added a inverted dropdown arrow and removed no more needed background color for buttons on Glass background.
Comment 4 Andreas Nilsson (:andreasn) 2012-01-08 09:35:10 PST
Created attachment 586815 [details]
screenshot

Looking at the icons in action, they look somewhat small and weak compared to the Firefox icons, so I'm going to take another stab at them.
Comment 5 Andreas Nilsson (:andreasn) 2012-01-08 09:36:38 PST
Comment on attachment 586666 [details] [diff] [review]
Firefox-style on tabbar-toolbar v2

Marking as ui-r minus as I'm not quite happy with the icons yet.
Comment 6 Andreas Nilsson (:andreasn) 2012-01-10 07:49:57 PST
Created attachment 587318 [details] [diff] [review]
New patch with updated icons

New icons that looks more bold and similar to the Firefox icons.
Comment 7 Andreas Nilsson (:andreasn) 2012-01-10 07:53:36 PST
Created attachment 587320 [details]
above patch in action
Comment 8 Richard Marti (:Paenglab) 2012-01-10 07:57:17 PST
(In reply to Andreas Nilsson (:andreasn) from comment #6)
> Created attachment 587318 [details] [diff] [review]
> New patch with updated icons
> 
> New icons that looks more bold and similar to the Firefox icons.

Should this patch go to review or is it okay for check-in?
Comment 9 Andreas Nilsson (:andreasn) 2012-01-10 08:36:49 PST
(In reply to Richard Marti [:paenglab] from comment #8)
> (In reply to Andreas Nilsson (:andreasn) from comment #6)
> > Created attachment 587318 [details] [diff] [review]
> > New patch with updated icons
> > 
> > New icons that looks more bold and similar to the Firefox icons.
> 
> Should this patch go to review or is it okay for check-in?

I think it would be good to get a second opinion about the graphics. I haven't touched the css, so I can do the code review I assume.
Comment 10 Blake Winton (:bwinton) (:☕️) 2012-01-12 13:19:21 PST
Comment on attachment 587318 [details] [diff] [review]
New patch with updated icons

Yeah, these definitely look better to me.  ui-r=me!

(Although they do highlight the difference of the quick-filter toggle, which I think we might want to fix now...  Or maybe just remove it?)
Comment 11 Andreas Nilsson (:andreasn) 2012-01-17 08:34:37 PST
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)

> (Although they do highlight the difference of the quick-filter toggle, which
> I think we might want to fix now...  Or maybe just remove it?)

I think there is another bug open about that with a patch. I recall running it, but it seems I lost the bug number.
Comment 12 Andreas Nilsson (:andreasn) 2012-01-17 09:09:44 PST
Comment on attachment 587318 [details] [diff] [review]
New patch with updated icons

Code looks good!
Comment 13 Richard Marti (:Paenglab) 2012-01-17 10:05:56 PST
(In reply to Andreas Nilsson (:andreasn) from comment #11)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> 
> > (Although they do highlight the difference of the quick-filter toggle, which
> > I think we might want to fix now...  Or maybe just remove it?)
> 
> I think there is another bug open about that with a patch. I recall running
> it, but it seems I lost the bug number.

This would be Bug 633679 because when the QFB button is a toolbarbutton-1 it wil behave like the other buttons.
Comment 14 Mark Banner (:standard8, afk until Dec) 2012-01-21 03:05:34 PST
Checked in: http://hg.mozilla.org/comm-central/rev/bdd7940e1455

Note You need to log in before you can comment on or make changes to this bug.