Inconsistency in styling of buttons in tabs-toolbar

RESOLVED FIXED in Thunderbird 12.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: andreasn, Assigned: Paenglab)

Tracking

11 Branch
Thunderbird 12.0
x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 586067 [details]
Thunderbird on top, Firefox on bottom

It seems we have at least three different ways we style buttons in the tabs-toolbar area on Aero (the area below the window controls). Either as heavier buttons (quicksearch), full color icons (calendar/todo) or white icons with a black outline (tabs dropdown).
Firefox styles all these items as in the last example. I think we should do that too.
(Reporter)

Comment 1

6 years ago
Created attachment 586299 [details] [diff] [review]
patch v1 - icons (wip)

This is the icons part of the patch, no css yet. Probably tomorrow.
(Assignee)

Comment 2

6 years ago
Created attachment 586572 [details] [diff] [review]
Firefox-style on tabbar-toolbar

On the tabbar-toolbar the icons are now inverted and the buttons have the All-tabs button styling on hover and checked (like Firefox).

I haven't gave special styles to the QFB button because Bug 633679 will change it to a standard toolbarbutton-1 which makes additional styling needless.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #586572 - Flags: ui-review?(nisses.mail)
Attachment #586572 - Flags: review?(nisses.mail)
(Assignee)

Comment 3

6 years ago
Created attachment 586666 [details] [diff] [review]
Firefox-style on tabbar-toolbar v2

Added a inverted dropdown arrow and removed no more needed background color for buttons on Glass background.
Attachment #586572 - Attachment is obsolete: true
Attachment #586572 - Flags: ui-review?(nisses.mail)
Attachment #586572 - Flags: review?(nisses.mail)
Attachment #586666 - Flags: ui-review?(nisses.mail)
Attachment #586666 - Flags: review?(nisses.mail)
(Reporter)

Comment 4

6 years ago
Created attachment 586815 [details]
screenshot

Looking at the icons in action, they look somewhat small and weak compared to the Firefox icons, so I'm going to take another stab at them.
(Reporter)

Comment 5

6 years ago
Comment on attachment 586666 [details] [diff] [review]
Firefox-style on tabbar-toolbar v2

Marking as ui-r minus as I'm not quite happy with the icons yet.
Attachment #586666 - Flags: ui-review?(nisses.mail) → ui-review-
(Reporter)

Comment 6

5 years ago
Created attachment 587318 [details] [diff] [review]
New patch with updated icons

New icons that looks more bold and similar to the Firefox icons.
(Reporter)

Comment 7

5 years ago
Created attachment 587320 [details]
above patch in action
(Assignee)

Comment 8

5 years ago
(In reply to Andreas Nilsson (:andreasn) from comment #6)
> Created attachment 587318 [details] [diff] [review]
> New patch with updated icons
> 
> New icons that looks more bold and similar to the Firefox icons.

Should this patch go to review or is it okay for check-in?
(Reporter)

Comment 9

5 years ago
(In reply to Richard Marti [:paenglab] from comment #8)
> (In reply to Andreas Nilsson (:andreasn) from comment #6)
> > Created attachment 587318 [details] [diff] [review]
> > New patch with updated icons
> > 
> > New icons that looks more bold and similar to the Firefox icons.
> 
> Should this patch go to review or is it okay for check-in?

I think it would be good to get a second opinion about the graphics. I haven't touched the css, so I can do the code review I assume.
(Reporter)

Updated

5 years ago
Attachment #587318 - Flags: ui-review?(bwinton)
Attachment #587318 - Flags: review?(nisses.mail)
(Assignee)

Updated

5 years ago
Attachment #586666 - Attachment is obsolete: true
Attachment #586666 - Flags: review?(nisses.mail)
Comment on attachment 587318 [details] [diff] [review]
New patch with updated icons

Yeah, these definitely look better to me.  ui-r=me!

(Although they do highlight the difference of the quick-filter toggle, which I think we might want to fix now...  Or maybe just remove it?)
Attachment #587318 - Flags: ui-review?(bwinton) → ui-review+
(Reporter)

Comment 11

5 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)

> (Although they do highlight the difference of the quick-filter toggle, which
> I think we might want to fix now...  Or maybe just remove it?)

I think there is another bug open about that with a patch. I recall running it, but it seems I lost the bug number.
(Reporter)

Comment 12

5 years ago
Comment on attachment 587318 [details] [diff] [review]
New patch with updated icons

Code looks good!
Attachment #587318 - Flags: review?(nisses.mail) → review+
(Assignee)

Comment 13

5 years ago
(In reply to Andreas Nilsson (:andreasn) from comment #11)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> 
> > (Although they do highlight the difference of the quick-filter toggle, which
> > I think we might want to fix now...  Or maybe just remove it?)
> 
> I think there is another bug open about that with a patch. I recall running
> it, but it seems I lost the bug number.

This would be Bug 633679 because when the QFB button is a toolbarbutton-1 it wil behave like the other buttons.
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/bdd7940e1455
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0

Updated

5 years ago
Depends on: 721249
You need to log in before you can comment on or make changes to this bug.