Last Comment Bug 715501 - GCLI should be built with the latest version of dryice
: GCLI should be built with the latest version of dryice
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: P2 normal (vote)
: Firefox 12
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 07:48 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-01-13 10:36 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
upload 1 (2.83 KB, patch)
2012-01-10 02:59 PST, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-05 07:48:56 PST
We shouldn't have dryice embedded in gcli, it should be used via npm
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-10 02:59:22 PST
Created attachment 587267 [details] [diff] [review]
upload 1


This effectively no-op change is a result of upgrading to the latest dryice which removed the 'ignored modules' feature, replacing it (in our build) with a filter.

For details of the build changes that lead to this:
  https://github.com/campd/gcli/pull/13
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-11 10:16:29 PST
Bug triage, filter on PEGASUS.
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-11 10:18:21 PST
Bug triage, filter on PEGASUS.
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-11 15:19:18 PST
https://tbpl.mozilla.org/?tree=Try&rev=b305229cfd64
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-12 10:40:20 PST
https://tbpl.mozilla.org/?tree=Fx-Team&rev=85c42ab04ac3
Comment 6 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-01-13 02:53:53 PST
https://hg.mozilla.org/mozilla-central/rev/1fe52552b302

Note You need to log in before you can comment on or make changes to this bug.