715604 - Logging in does not follow original request

Status: VERIFIED DUPLICATE of bug 810992

(Participation Infrastructure :: Phonebook, defect, P2)

Description

[Josh Matthews [:jdm]]

If I visit a link to mozillians.org and I am not logged in, I would expect that I would be taken to the original link upon logging in. Instead, I am always redirected to my profile.

Comment 1

[Aakash Desai [:aakashd]]

This sounds like

Comment 2

[Aakash Desai [:aakashd]]

SUSPENSE.

Comment 3

[Aakash Desai [:aakashd]]

This sounds like a user complaint on the 6-hour session cookie we've had on mozillians for awhile.

Comment 4

[Josh Matthews [:jdm]]

I don't see the connection. This occurs when I visit a link, get redirected to the login page, login immediately, and then am taken to my profile.

Comment 5

[Josh Matthews [:jdm]]

From digging through the code, I'm pretty sure this was a regression introduced along with BrowserID, but I couldn't find the place where the actual redirect occurs upon successful login.

Comment 6

[Josh Matthews [:jdm]]

Aha, the culprit is at https://github.com/mozilla/mozillians/blob/master/apps/browserid/views.py#L41 . This was introduced with BrowserID; previously we were presumably using the default django auth stuff that tied in with django.contrib.auth.redirect_to_login, which has some magic that redirects to the given next URL on successfully logging in.

Comment 7

[Aakash Desai [:aakashd]]

Ah, I see what the issue is. Thanks for flagging down the issue. Interested in offering a commit, Josh?

Comment 8

[Josh Matthews [:jdm]]

Ordinarily yes, but there's enough uncertainty in my understanding that I'll leave it to someone more experienced.

Comment 11

[Matt Brandt [:mbrandt]]

Bumping to QA verified duplicate.