71563 - string leak in nsTransferable.cpp

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While higlighting some text randomly while running under the Boehm GC
(in the xlib port, actually), I ran into a leak of a string in
nsTransferable.cpp.  I'll attach what I think is the fix.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: proposed patch

Comment 2

[Håkan Waara]

r=hwaara

Comment 3

[Mike Pinkerton (not reading bugmail)]

there's actually another instance of the same leak in the same file. I'll fix 
them both and use nsXPIDLCString to wrap it instead of having to do a Free. Patch 
forthcoming.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Attachment: [patch] fixes both leaks, uses nsXPIDLCString

Comment 5

[Mike Pinkerton (not reading bugmail)]

taking for my very own. sfraser, can i get an sr?

Comment 6

[Peter "jag" Annema]

I like it, r=jag

Comment 7

[Simon Fraser [no longer active]]

sr=sfraser on the second patch. Maybe you could use DOMStrings in your idl to 
avoid allocating altogether?

Comment 8

[Mike Pinkerton (not reading bugmail)]

fixed.