[Skia] Unitialized variable 'margin' in SkDraw.cpp

RESOLVED FIXED in mozilla12

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Filed Skia bug: http://code.google.com/p/skia/issues/detail?id=435
(Assignee)

Comment 1

5 years ago
Created attachment 586268 [details] [diff] [review]
Initialize the margin
Attachment #586268 - Flags: review?(jmuizelaar)
Attachment #586268 - Flags: review?(jmuizelaar) → review?(gwright)
Looks good to me, but this should really be submitted upstream.
"unitialized-margin.patch" = typo. Should be uninitialized?
(In reply to George Wright from comment #2)
> Looks good to me, but this should really be submitted upstream.

George, can you take care of upstreaming this?
Yep, I'll get on that tomorrow.
Submitted for review @ http://codereview.appspot.com/5519056/
Attachment #586268 - Flags: review?(gwright) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8763e1f49736
Assignee: nobody → matt.woodrow
https://hg.mozilla.org/mozilla-central/rev/8763e1f49736
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.