Last Comment Bug 715718 - [Skia] Unitialized variable 'margin' in SkDraw.cpp
: [Skia] Unitialized variable 'margin' in SkDraw.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: Matt Woodrow (:mattwoodrow)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 16:19 PST by Matt Woodrow (:mattwoodrow)
Modified: 2012-01-19 10:50 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Initialize the margin (2.11 KB, patch)
2012-01-05 16:20 PST, Matt Woodrow (:mattwoodrow)
gwright: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2012-01-05 16:19:28 PST
Filed Skia bug: http://code.google.com/p/skia/issues/detail?id=435
Comment 1 Matt Woodrow (:mattwoodrow) 2012-01-05 16:20:42 PST
Created attachment 586268 [details] [diff] [review]
Initialize the margin
Comment 2 George Wright (:gw280) (:gwright) 2012-01-05 16:50:50 PST
Looks good to me, but this should really be submitted upstream.
Comment 3 George Wright (:gw280) (:gwright) 2012-01-05 17:48:04 PST
"unitialized-margin.patch" = typo. Should be uninitialized?
Comment 4 Jeff Muizelaar [:jrmuizel] 2012-01-05 17:55:57 PST
(In reply to George Wright from comment #2)
> Looks good to me, but this should really be submitted upstream.

George, can you take care of upstreaming this?
Comment 5 George Wright (:gw280) (:gwright) 2012-01-05 17:56:37 PST
Yep, I'll get on that tomorrow.
Comment 6 George Wright (:gw280) (:gwright) 2012-01-06 07:53:31 PST
Submitted for review @ http://codereview.appspot.com/5519056/
Comment 7 Matt Woodrow (:mattwoodrow) 2012-01-18 20:52:42 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/8763e1f49736
Comment 8 Matt Brubeck (:mbrubeck) 2012-01-19 10:50:45 PST
https://hg.mozilla.org/mozilla-central/rev/8763e1f49736

Note You need to log in before you can comment on or make changes to this bug.