715756 - Workers: Enable TI and allow JIT hardening to be disabled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Looks like we forgot to enable TI on workers when it landed. Also this JIT hardening thing should be exposed too.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/mozilla-central/rev/8b0437df0da3

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Regression caused by (bug #): 
Not really a regression

User impact if declined: 
Workers will be slower than main thread.

Testing completed (on m-c, etc.): 
Tons of mochitests.

Risk to taking this patch (and alternatives if risky):
Almost none. TI is stable now, and this patch is very simple.

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Triage Comment]
I want to keep this in the queue for discussion at Tuesday's channel meeting.

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Triage Comment]
We're concerned with the possibility of an unexpected interaction between TI and workers. Given the fact that this appears to only have a user-impact related to performance, we'll let this ride the train.