Closed Bug 715756 Opened 9 years ago Closed 9 years ago

Workers: Enable TI and allow JIT hardening to be disabled

Categories

(Core :: DOM: Core & HTML, defect)

11 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox9 --- affected
firefox10 - affected
firefox11 - affected
firefox12 --- fixed

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
Looks like we forgot to enable TI on workers when it landed. Also this JIT hardening thing should be exposed too.
Attachment #586295 - Flags: review?(jonas)
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/8b0437df0da3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Approval Request Comment]
Regression caused by (bug #): 
Not really a regression

User impact if declined: 
Workers will be slower than main thread.

Testing completed (on m-c, etc.): 
Tons of mochitests.

Risk to taking this patch (and alternatives if risky):
Almost none. TI is stable now, and this patch is very simple.
Attachment #586295 - Flags: approval-mozilla-beta?
Attachment #586295 - Flags: approval-mozilla-aurora?
Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Triage Comment]
I want to keep this in the queue for discussion at Tuesday's channel meeting.
Comment on attachment 586295 [details] [diff] [review]
Patch, v1

[Triage Comment]
We're concerned with the possibility of an unexpected interaction between TI and workers. Given the fact that this appears to only have a user-impact related to performance, we'll let this ride the train.
Attachment #586295 - Flags: approval-mozilla-beta?
Attachment #586295 - Flags: approval-mozilla-beta-
Attachment #586295 - Flags: approval-mozilla-aurora?
Attachment #586295 - Flags: approval-mozilla-aurora-
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.