Last Comment Bug 715791 - Preprocessor.py doesn't preserve line numbers when preprocessing Java
: Preprocessor.py doesn't preserve line numbers when preprocessing Java
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: Kartikaya Gupta (email:kats@mozilla.com)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-05 20:36 PST by Kartikaya Gupta (email:kats@mozilla.com)
Modified: 2012-01-10 18:54 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Treat java files same as js files (1.02 KB, patch)
2012-01-05 20:36 PST, Kartikaya Gupta (email:kats@mozilla.com)
no flags Details | Diff | Review
Treat java files same as js files (v2) (1.98 KB, patch)
2012-01-05 20:53 PST, Kartikaya Gupta (email:kats@mozilla.com)
ted: review+
Details | Diff | Review

Description Kartikaya Gupta (email:kats@mozilla.com) 2012-01-05 20:36:57 PST
Created attachment 586337 [details] [diff] [review]
Treat java files same as js files

This means that java stack traces from Fennec on android are often off by a line, which is mildly annoying.

Simple patch updates a regex so java files are treated like js files and have extra padding inserted to make line numbers line up. Pushed patch to try at https://tbpl.mozilla.org/?tree=Try&rev=3fdb9406cf51 to verify it doesn't break any builds.
Comment 1 Kartikaya Gupta (email:kats@mozilla.com) 2012-01-05 20:53:43 PST
Created attachment 586340 [details] [diff] [review]
Treat java files same as js files (v2)

Apparently I need to make the same change to js/src/config/Preprocessor.py. New try push at https://tbpl.mozilla.org/?tree=Try&rev=92c4e6163b89 (and sorry for the bugspam).
Comment 2 Kartikaya Gupta (email:kats@mozilla.com) 2012-01-10 07:04:34 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/4796cf23c294
Comment 3 Ed Morley [:emorley] 2012-01-10 18:54:59 PST
https://hg.mozilla.org/mozilla-central/rev/4796cf23c294

Note You need to log in before you can comment on or make changes to this bug.