Closed Bug 715791 Opened 8 years ago Closed 8 years ago

Preprocessor.py doesn't preserve line numbers when preprocessing Java

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file, 1 obsolete file)

This means that java stack traces from Fennec on android are often off by a line, which is mildly annoying.

Simple patch updates a regex so java files are treated like js files and have extra padding inserted to make line numbers line up. Pushed patch to try at https://tbpl.mozilla.org/?tree=Try&rev=3fdb9406cf51 to verify it doesn't break any builds.
Attachment #586337 - Flags: review?(ted.mielczarek)
Apparently I need to make the same change to js/src/config/Preprocessor.py. New try push at https://tbpl.mozilla.org/?tree=Try&rev=92c4e6163b89 (and sorry for the bugspam).
Attachment #586337 - Attachment is obsolete: true
Attachment #586337 - Flags: review?(ted.mielczarek)
Attachment #586340 - Flags: review?(ted.mielczarek)
Attachment #586340 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/4796cf23c294
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.