Preprocessor.py doesn't preserve line numbers when preprocessing Java

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 586337 [details] [diff] [review]
Treat java files same as js files

This means that java stack traces from Fennec on android are often off by a line, which is mildly annoying.

Simple patch updates a regex so java files are treated like js files and have extra padding inserted to make line numbers line up. Pushed patch to try at https://tbpl.mozilla.org/?tree=Try&rev=3fdb9406cf51 to verify it doesn't break any builds.
Attachment #586337 - Flags: review?(ted.mielczarek)
Created attachment 586340 [details] [diff] [review]
Treat java files same as js files (v2)

Apparently I need to make the same change to js/src/config/Preprocessor.py. New try push at https://tbpl.mozilla.org/?tree=Try&rev=92c4e6163b89 (and sorry for the bugspam).
Attachment #586337 - Attachment is obsolete: true
Attachment #586337 - Flags: review?(ted.mielczarek)
Attachment #586340 - Flags: review?(ted.mielczarek)
Attachment #586340 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4796cf23c294
https://hg.mozilla.org/mozilla-central/rev/4796cf23c294
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.