715807 - crash CMbxScanner::CleanUp

Status: RESOLVED FIXED

(Thunderbird :: Migration, defect)

Description

[Makoto Kato [:m_kato]]

This bug was filed from the Socorro interface and is 
report bp-bca944b5-968c-40eb-aa30-fc9482120104 .
============================================================= 
0 	xul.dll 	CMbxScanner::CleanUp 	mailnews/import/oexpress/nsOEMailbox.cpp:292
1 	xul.dll 	CMbxScanner::Initialize 	mailnews/import/oexpress/nsOEMailbox.cpp:247
2 	xul.dll 	CImportMailbox::ImportMailbox 	mailnews/import/oexpress/nsOEMailbox.cpp:158
3 	xul.dll 	ImportOEMailImpl::ImportMailbox 	mailnews/import/oexpress/nsOEImport.cpp:476
4 	xul.dll 	ImportMailThread 	mailnews/import/src/nsImportMail.cpp:908
5 	nspr4.dll 	_PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:426
6 	nspr4.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:122
7 	msvcr80.dll 	msvcr80.dll@0x29ba 	
8 	msvcr80.dll 	msvcr80.dll@0x2a46 	
9 	ntdll.dll 	__RtlUserThreadStart 	
10 	ntdll.dll 	_RtlUserThreadStart


When CMbxScanner::Initialize is failed, thunderbird will crash.  Because m_mbxFileInputStream or m_dstFileOutputStream may be null on CleanUp()

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[David :Bienvenu]

Comment on attachment 587254 [details] [diff] [review]
fix

Review of attachment 587254 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thx!

Comment 3

[David :Bienvenu]

I'm wondering if we want this for tb 10 and tb 11, since it looks safe, and the outlook import changes that perhaps caused this are in tb 10 and 11.

Comment 4

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/comm-central/rev/59b240e1e76c

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 587254 [details] [diff] [review]
fix

This crash occurs on 9.0.1.

Comment 6

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/f0040534a14a
http://hg.mozilla.org/releases/comm-beta/rev/d42be64ed94c