715853 - AggregatingScheduler should update its builders on reconfig and allow resetting the state

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

AggregatingScheduler doesn't update its up/downstream builders on reconfig what may be a problem when we rename builder names (undead scheduler).

Comment 1

[Rail Aliiev [:rail]]

Attachment: compare remainingBuilders and upstreamBuilders

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 586408 [details] [diff] [review]
compare remainingBuilders and upstreamBuilders

New versin will be ready a little bit later.

Comment 3

[Rail Aliiev [:rail]]

Attachment: add trigger() and startService()

* Inherit Triggerable to make buildbot happy. It uses isinstance(scheduler, Ttiggerable)
* add trigger method which resets the state
* _startService now checks additions and removal now

Example usage in process/release.py:

    aggregating_shedulers = []
    for s in schedulers:
        if isinstance(s, AggregatingScheduler):
            aggregating_shedulers.append(s.name)
    if aggregating_shedulers:
        scheduler_reset_factory = BuildFactory()
        scheduler_reset_factory.addStep(Trigger(
            schedulerNames=aggregating_shedulers,
        ))
        builders.append({
            'name': builderPrefix(
                '%s_reset_schedulers' % releaseConfig['productName']),
            'slavenames': all_slaves,
            'category': builderPrefix(''),
            'builddir': builderPrefix(
                '%s_reset_schedulers' % releaseConfig['productName']),
            'factory': scheduler_reset_factory,
        })

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 587304 [details] [diff] [review]
add trigger() and startService()

http://hg.mozilla.org/build/buildbotcustom/rev/0b809be1d315