Remove JSRuntime::gcEmptyArenaPoolLifespan

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Igor Bukanov, Assigned: Igor Bukanov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
JSRuntime::gcEmptyArenaPoolLifespan is no longer used for anything, but we still have have the code to read/write it. We should remove it.
(Assignee)

Comment 1

5 years ago
Created attachment 586411 [details] [diff] [review]
v1

The patch removes unused code.
Assignee: general → igor
Attachment #586411 - Flags: review?(wmccloskey)

Updated

5 years ago
Attachment #586411 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c34bef1d9ea
Bug 716232 (SEGV crash in JS garbage collection code at ChatZilla startup) appeared about when this patch landed. Could someone please have a look?
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7c34bef1d9ea
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7c34bef1d9ea - this has landed to mc some time ago
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

5 years ago
(In reply to Tony Mechelynck [:tonymec] from comment #3)
> Bug 716232 (SEGV crash in JS garbage collection code at ChatZilla startup)
> appeared about when this patch landed. Could someone please have a look?

This bug just eliminates unused code and unused field from JSRuntime. Sometimes such changes could trigger a regression, but typically such regression would be a serious bug that would be rather visible. Do you have more indications that this bug indeed caused that ChatZilla problem?
(In reply to Igor Bukanov from comment #6)
> (In reply to Tony Mechelynck [:tonymec] from comment #3)
> > Bug 716232 (SEGV crash in JS garbage collection code at ChatZilla startup)
> > appeared about when this patch landed. Could someone please have a look?
> 
> This bug just eliminates unused code and unused field from JSRuntime.
> Sometimes such changes could trigger a regression, but typically such
> regression would be a serious bug that would be rather visible. Do you have
> more indications that this bug indeed caused that ChatZilla problem?

That ChatZilla problem appeared between the SeaMonkey nightlies built around half past midnight Mountain View time on the 6th (last good) and 7th (first bad) of January. I tried to determine which changesets were "most likely" to have caused the regression and noted the results of my detective work in bug 716232 comment #5

Since Jan.7 (and never before that) I experience a SEGV crash at every startup of ChatZilla-on-trunk in both Firefox and SeaMonkey; the top symbol on the crash stack is not strictly constant but always in the JS garbage collector and often at symbols with "Arena" in their names.
You need to log in before you can comment on or make changes to this bug.